[jira] [Comment Edited] (CRUNCH-491) Add an Xml File Source

["mac champion (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CRUNCH-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293694#comment-14293694 ] 

mac champion edited comment on CRUNCH-491 at 1/27/15 3:49 PM:
--------------------------------------------------------------

Yeah, that sounds good to me. At least we will get something started, XML-wise. This will provide some very good baseline functionality. 
+1

Edit: Just took a closer look into the code/patch. You  might want to try to avoid dealing with byte arrays and use char arrays instead. Also, you should probably not hard-code or assume UTF-8 formatting. 


was (Author: champgm):
Yeah, that sounds good to me. At least we will get something started, XML-wise. This will provide some very good baseline functionality. 
+1

> Add an Xml File Source
> ----------------------
>
>                 Key: CRUNCH-491
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-491
>             Project: Crunch
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.11.0
>            Reporter: Christian Tzolov
>            Assignee: Christian Tzolov
>            Priority: Minor
>              Labels: inputformat, source, xml
>         Attachments: CRUNCH-491.patch, CRUNCH-491b.patch
>
>
> Large XML documents that are composed of a repetitive XML elements can be broken into chunks delimited by the start and end tags of those elements.
> The XmlSource should process XML files and extract out the XML between the pre-configured start / end tags.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)