You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/12 05:45:30 UTC

[GitHub] [spark] LuciferYang opened a new pull request, #38215: [MINOR][BUILD] Add `dist`dir to `fileset` of`maven-clean-plugin`

LuciferYang opened a new pull request, #38215:
URL: https://github.com/apache/spark/pull/38215

   ### What changes were proposed in this pull request?
   This pr add add `dist` to  `fileset` of`maven-clean-plugin` to make `mvn clean` can delete the `dist` dir which created by `dev/make-distribution.sh`.
   
   
   ### Why are the changes needed?
   `dev/make-distribution.sh` will create a dist dir but no one cleaned it up.
   
    
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Local test to confirm that `dist` dir can be cleaned
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #38215: [MINOR][BUILD] Add `dist`dir to `fileset` of`maven-clean-plugin`

Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38215:
URL: https://github.com/apache/spark/pull/38215#issuecomment-1276848149

   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #38215: [MINOR][BUILD] Add `dist`dir to `fileset` of`maven-clean-plugin`

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38215:
URL: https://github.com/apache/spark/pull/38215#issuecomment-1276950357

   thanks @srowen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen closed pull request #38215: [MINOR][BUILD] Add `dist`dir to `fileset` of`maven-clean-plugin`

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #38215: [MINOR][BUILD] Add `dist`dir to  `fileset` of`maven-clean-plugin` 
URL: https://github.com/apache/spark/pull/38215


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #38215: [MINOR][BUILD] Add `dist`dir to `fileset` of`maven-clean-plugin`

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38215:
URL: https://github.com/apache/spark/pull/38215#issuecomment-1275624878

   or should we add `m -rf "$DISTDIR"` after line 291?
   
   https://github.com/apache/spark/blob/790a697f81ef4af8c380a4d4c1690e7737d6c7ed/dev/make-distribution.sh#L284-L292
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org