You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2019/12/17 01:54:09 UTC
[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request
#369: Hdds 2755. Compare transactionID and updateID of Volume operations to
avoid replaying transactions
bharatviswa504 commented on a change in pull request #369: Hdds 2755. Compare transactionID and updateID of Volume operations to avoid replaying transactions
URL: https://github.com/apache/hadoop-ozone/pull/369#discussion_r358562274
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/volume/OMVolumeSetQuotaResponse.java
##########
@@ -36,22 +36,22 @@
public class OMVolumeSetQuotaResponse extends OMClientResponse {
private OmVolumeArgs omVolumeArgs;
- public OMVolumeSetQuotaResponse(OmVolumeArgs omVolumeArgs,
- @Nonnull OMResponse omResponse) {
+ public OMVolumeSetQuotaResponse(@Nonnull OMResponse omResponse,
+ OmVolumeArgs omVolumeArgs) {
super(omResponse);
this.omVolumeArgs = omVolumeArgs;
}
+ public OMVolumeSetQuotaResponse(@Nonnull OMResponse omResponse) {
+ super(omResponse);
+ }
+
@Override
public void addToDBBatch(OMMetadataManager omMetadataManager,
BatchOperation batchOperation) throws IOException {
- // For OmResponse with failure, this should do nothing. This method is
- // not called in failure scenario in OM code.
- if (getOMResponse().getStatus() == OzoneManagerProtocolProtos.Status.OK) {
- omMetadataManager.getVolumeTable().putWithBatch(batchOperation,
- omMetadataManager.getVolumeKey(omVolumeArgs.getVolume()),
- omVolumeArgs);
- }
+ omMetadataManager.getVolumeTable().putWithBatch(batchOperation,
Review comment:
We should not read from DB/cache without lock, so that is the reason for having OmVolumeArgs as an argument to the constructor. Same applies to other places also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org