[GitHub] [calcite] rubenada commented on a change in pull request #1584: [CALCITE-3503] NPE at VolcanoPlanner#isValid when DEBUG is enabled

[GitBox <gi...@apache.org>]

rubenada commented on a change in pull request #1584: [CALCITE-3503] NPE at VolcanoPlanner#isValid when DEBUG is enabled
URL: https://github.com/apache/calcite/pull/1584#discussion_r346719028
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
 ##########
 @@ -877,6 +877,10 @@ public RelSubset ensureRegistered(RelNode rel, RelNode equivRel) {
    * Checks internal consistency.
    */
   protected boolean isValid(Litmus litmus) {
+    if (this.getRoot() == null) {
+      return true;
 
 Review comment:
   I'm not very familiar with VolcanoPlanner implementation details, but I have the same impression as @danny0405 ; I think that in the case of no root, we could get the cluster from somewhere else (maybe from the first subset that we process?).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services