You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/22 16:15:23 UTC

[GitHub] [spark] cloud-fan opened a new pull request #24678: [SPARK-27806][SQL] byName/byPosition should apply to struct fields as well

cloud-fan opened a new pull request #24678: [SPARK-27806][SQL] byName/byPosition should apply to struct fields as well
URL: https://github.com/apache/spark/pull/24678
 
 
   ## What changes were proposed in this pull request?
   
   When writing a query to data source v2, we have 2 modes to resolve the input query's output: byName or byPosition.
   
   For byName mode, we would reorder the top level columns according to the name, and add type cast if possible. If the names don't match, we fail.
   
   For byPosition mode, we don't do the reorder, and just add type cast directly if possible.
   
   However, for struct type fields, we always apply byName mode. We should ignore the name difference if byPosition mode is used.
   
   ## How was this patch tested?
   
   new tests
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org