You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/10 06:24:05 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #35798: [SPARK-38451][R][TESTS] Fix `make_date` test case to pass with ANSI mode

HyukjinKwon opened a new pull request #35798:
URL: https://github.com/apache/spark/pull/35798


   ### What changes were proposed in this pull request?
   
   This PR proposes to fix `expose make_date expression in R` test case to pass with ANSI mode enabled by excluding data that throws an exception when ANSI mode is enabled.
   
   ### Why are the changes needed?
   
   To make the tests independent from configurations, and to improve test coverage (ANSI mode will be tested with GitHub Actions).
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, test-only.
   
   ### How was this patch tested?
   
   Manually tested.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35798: [SPARK-38451][R][TESTS] Fix `make_date` test case to pass with ANSI mode

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35798:
URL: https://github.com/apache/spark/pull/35798#issuecomment-1063707136


   I honestly didn't test it it my local because the change looked straightforward. Should wait for the results in the CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gengliangwang closed pull request #35798: [SPARK-38451][R][TESTS] Fix `make_date` test case to pass with ANSI mode

Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #35798:
URL: https://github.com/apache/spark/pull/35798


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon removed a comment on pull request #35798: [SPARK-38451][R][TESTS] Fix `make_date` test case to pass with ANSI mode

Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #35798:
URL: https://github.com/apache/spark/pull/35798#issuecomment-1063707136


   I honestly didn't test it it my local because the change looked straightforward. Should wait for the results in the CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #35798: [SPARK-38451][R][TESTS] Fix `make_date` test case to pass with ANSI mode

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #35798:
URL: https://github.com/apache/spark/pull/35798#discussion_r823481659



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2706,7 +2706,7 @@ object SQLConf {
       "standard directly, but their behaviors align with ANSI SQL's style")
     .version("3.0.0")
     .booleanConf
-    .createWithDefault(false)
+    .createWithDefault(true)

Review comment:
       I will revert this back once it verifies the test passes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #35798: [SPARK-38451][R][TESTS] Fix `make_date` test case to pass with ANSI mode

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #35798:
URL: https://github.com/apache/spark/pull/35798#discussion_r823589894



##########
File path: R/pkg/tests/fulltests/test_sparkSQL.R
##########
@@ -2051,13 +2051,19 @@ test_that("date functions on a DataFrame", {
 })
 
 test_that("SPARK-37108: expose make_date expression in R", {

Review comment:
       With ANSI: https://github.com/HyukjinKwon/spark/runs/5493047129?check_suite_focus=true

##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2706,7 +2706,7 @@ object SQLConf {
       "standard directly, but their behaviors align with ANSI SQL's style")
     .version("3.0.0")
     .booleanConf
-    .createWithDefault(false)
+    .createWithDefault(true)

Review comment:
       ```suggestion
       .createWithDefault(false)
   ```

##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2706,7 +2706,7 @@ object SQLConf {
       "standard directly, but their behaviors align with ANSI SQL's style")
     .version("3.0.0")
     .booleanConf
-    .createWithDefault(false)
+    .createWithDefault(true)

Review comment:
       I will revert this back once it verifies the test passes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gengliangwang commented on pull request #35798: [SPARK-38451][R][TESTS] Fix `make_date` test case to pass with ANSI mode

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #35798:
URL: https://github.com/apache/spark/pull/35798#issuecomment-1064219854


   Thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35798: [SPARK-38451][R][TESTS] Fix `make_date` test case to pass with ANSI mode

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35798:
URL: https://github.com/apache/spark/pull/35798#issuecomment-1064222307


   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org