You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/03 01:40:05 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #13881: [BEAM-11476] Resolve flaky tests

TheNeuralBit commented on a change in pull request #13881:
URL: https://github.com/apache/beam/pull/13881#discussion_r569037444



##########
File path: sdks/python/apache_beam/runners/interactive/interactive_environment_test.py
##########
@@ -180,91 +180,81 @@ def test_cleanup_invoked_when_new_env_replace_not_none_env(
       self, mocked_cleanup):
     ie._interactive_beam_env = None
     ie.new_env()
-    mocked_cleanup.assert_not_called()
     ie.new_env()
-    mocked_cleanup.assert_called_once()
+    mocked_cleanup.assert_called()

Review comment:
       This seems to change the meaning of the test. Do we not want to verify that cleanup is not called when _interactive_beam_env is None?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org