You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2014/03/18 00:25:35 UTC
Review Request 19329: Make it configurable to have partition columns
displayed separately or not.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19329/
-----------------------------------------------------------
Review request for hive and Jason Dere.
Bugs: HIVE-6689
https://issues.apache.org/jira/browse/HIVE-6689
Repository: hive-git
Description
-------
Make it configurable to have partition columns displayed separately or not.
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b0f5c49
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java de04cca
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java 0c49250
ql/src/test/queries/clientpositive/desc_tbl_part_cols.q PRE-CREATION
ql/src/test/results/clientpositive/desc_tbl_part_cols.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/19329/diff/
Testing
-------
Added a test case.
Thanks,
Ashutosh Chauhan
Re: Review Request 19329: Make it configurable to have partition columns
displayed separately or not.
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19329/#review37543
-----------------------------------------------------------
Ship it!
- Jason Dere
On March 17, 2014, 11:57 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19329/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 11:57 p.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-6689
> https://issues.apache.org/jira/browse/HIVE-6689
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Make it configurable to have partition columns displayed separately or not.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b0f5c49
> conf/hive-default.xml.template a8da2ca
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java de04cca
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java 0c49250
> ql/src/test/queries/clientpositive/desc_tbl_part_cols.q PRE-CREATION
> ql/src/test/results/clientpositive/desc_tbl_part_cols.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19329/diff/
>
>
> Testing
> -------
>
> Added a test case.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>
Re: Review Request 19329: Make it configurable to have partition columns
displayed separately or not.
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19329/
-----------------------------------------------------------
(Updated March 17, 2014, 11:57 p.m.)
Review request for hive and Jason Dere.
Changes
-------
Added description of new config in hive-site.xml.default
Bugs: HIVE-6689
https://issues.apache.org/jira/browse/HIVE-6689
Repository: hive-git
Description
-------
Make it configurable to have partition columns displayed separately or not.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b0f5c49
conf/hive-default.xml.template a8da2ca
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java de04cca
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java 0c49250
ql/src/test/queries/clientpositive/desc_tbl_part_cols.q PRE-CREATION
ql/src/test/results/clientpositive/desc_tbl_part_cols.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/19329/diff/
Testing
-------
Added a test case.
Thanks,
Ashutosh Chauhan
Re: Review Request 19329: Make it configurable to have partition columns
displayed separately or not.
Posted by Lefty Leverenz <le...@gmail.com>.
> On March 17, 2014, 11:42 p.m., Jason Dere wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 837
> > <https://reviews.apache.org/r/19329/diff/1/?file=525742#file525742line837>
> >
> > I'm sure Lefty will mention this too, I believe new config settings also should have updated entry in conf/hive-default.xml.template.
Yes, but no. It all depends on when HIVE-6037 gets committed because after that hive-default.xml.template will be generated from HiveConf.java, which will include descriptions in the parameter definitions. Anyway, the new patch for this jira has a description in hive-default.xml.template so that can go into HiveConf.java when the time comes.
- Lefty
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19329/#review37501
-----------------------------------------------------------
On March 17, 2014, 11:57 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19329/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 11:57 p.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-6689
> https://issues.apache.org/jira/browse/HIVE-6689
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Make it configurable to have partition columns displayed separately or not.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b0f5c49
> conf/hive-default.xml.template a8da2ca
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java de04cca
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java 0c49250
> ql/src/test/queries/clientpositive/desc_tbl_part_cols.q PRE-CREATION
> ql/src/test/results/clientpositive/desc_tbl_part_cols.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19329/diff/
>
>
> Testing
> -------
>
> Added a test case.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>
Re: Review Request 19329: Make it configurable to have partition columns
displayed separately or not.
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19329/#review37501
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/19329/#comment69047>
I'm sure Lefty will mention this too, I believe new config settings also should have updated entry in conf/hive-default.xml.template.
- Jason Dere
On March 17, 2014, 11:25 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19329/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 11:25 p.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-6689
> https://issues.apache.org/jira/browse/HIVE-6689
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Make it configurable to have partition columns displayed separately or not.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b0f5c49
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java de04cca
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java 0c49250
> ql/src/test/queries/clientpositive/desc_tbl_part_cols.q PRE-CREATION
> ql/src/test/results/clientpositive/desc_tbl_part_cols.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19329/diff/
>
>
> Testing
> -------
>
> Added a test case.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>