[GitHub] [pulsar] merlimat commented on a change in pull request #4465: Support key-shared subscribe mode for go client

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #4465: Support key-shared subscribe mode for go client
URL: https://github.com/apache/pulsar/pull/4465#discussion_r290320960
 
 

 ##########
 File path: pulsar-client-go/pulsar/consumer.go
 ##########
 @@ -44,6 +44,10 @@ const (
 	// Multiple consumer will be able to use the same subscription name but only 1 consumer will receive the messages.
 	// If that consumer disconnects, one of the other connected consumers will start receiving messages.
 	Failover
+
+	// Multiple consumer will be able to use the same subscription and all messages with the same key
+	// will be dispatched to only one consumer
+	keyShared
 
 Review comment:
   This should be start with capital letter too, like `Exclusive` and `Failover`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services