svn commit: r1889866 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFField.java

[ti...@apache.org]

Author: tilman
Date: Thu May 13 18:29:41 2021
New Revision: 1889866

URL: http://svn.apache.org/viewvc?rev=1889866&view=rev
Log:
PDFBOX-4892: optimize by avoiding string concat

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFField.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFField.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFField.java?rev=1889866&r1=1889865&r2=1889866&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFField.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFField.java Thu May 13 18:29:41 2021
@@ -116,26 +116,35 @@ public class FDFField implements COSObje
      */
     public void writeXML(Writer output) throws IOException
     {
-        output.write("<field name=\"" + getPartialFieldName() + "\">\n");
+        output.write("<field name=\"");
+        output.write(getPartialFieldName());
+        output.write("\">\n");
+
         Object value = getValue();
 
         if (value instanceof String)
         {
-            output.write("<value>" + escapeXML((String) value) + "</value>\n");
+            output.write("<value>");
+            output.write(escapeXML((String) value));
+            output.write("</value>\n");
         }
         else if (value instanceof List)
         {
             List<String> items = (List<String>) value;
             for (String item : items)
             {
-                output.write("<value>" + escapeXML(item) + "</value>\n");
+                output.write("<value>");
+                output.write(escapeXML(item));
+                output.write("</value>\n");
             }
         }
 
         String rt = getRichText();
         if (rt != null)
         {
-            output.write("<value-richtext>" + escapeXML(rt) + "</value-richtext>\n");
+            output.write("<value-richtext>");
+            output.write(escapeXML(rt));
+            output.write("</value-richtext>\n");
         }
         List<FDFField> kids = getKids();
         if (kids != null)