You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by "Gang Wu (Jira)" <ji...@apache.org> on 2023/02/03 07:10:00 UTC

[jira] [Updated] (ORC-1365) [C++] Use BlockBuffer to replace DataBuffer of rawInputBuffer in the CompressionStream

     [ https://issues.apache.org/jira/browse/ORC-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gang Wu updated ORC-1365:
-------------------------
    Description: 
Discussion from Github issue: [https://github.com/apache/orc/issues/1240]

In short, *CompressionStream* has fixed its input buffer to compression block size (which is 1M by default). Check here for reference: https://github.com/apache/orc/blob/main/c%2B%2B/src/Compression.cc#L108 . 

The piece of code can be improved by replacing its type from DataBuffer by BlockBuffer. In this way, it is able to start with a small initial size and automatically grow as needed.

  was:
Discussion from Github issue: [https://github.com/apache/orc/issues/1240]

In short, *CompressionStream* has fixed its input buffer to compression block size (which is 1M by default). Check here for reference: https://github.com/apache/orc/blob/main/c%2B%2B/src/Compression.cc#L108 . The piece of code can be improved by replacing its type from DataBuffer by BlockBuffer. In this way, it is able to start with a small initial size and automatically grow as needed.


> [C++] Use BlockBuffer to replace DataBuffer of rawInputBuffer in the CompressionStream
> --------------------------------------------------------------------------------------
>
>                 Key: ORC-1365
>                 URL: https://issues.apache.org/jira/browse/ORC-1365
>             Project: ORC
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Gang Wu
>            Priority: Major
>
> Discussion from Github issue: [https://github.com/apache/orc/issues/1240]
> In short, *CompressionStream* has fixed its input buffer to compression block size (which is 1M by default). Check here for reference: https://github.com/apache/orc/blob/main/c%2B%2B/src/Compression.cc#L108 . 
> The piece of code can be improved by replacing its type from DataBuffer by BlockBuffer. In this way, it is able to start with a small initial size and automatically grow as needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)