You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/11/20 08:06:33 UTC
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5312: Removing atscfg as a dependency in traffic_ops_golang
ocket8888 commented on a change in pull request #5312:
URL: https://github.com/apache/trafficcontrol/pull/5312#discussion_r527507200
##########
File path: traffic_ops/traffic_ops_golang/server/servers_assignment.go
##########
@@ -269,7 +277,9 @@ INSERT INTO deliveryservice_server (deliveryservice, server)
//need remap config location
var atsConfigLocation string
- if err := tx.QueryRow("SELECT value FROM parameter WHERE name = 'location' AND config_file = '" + atscfg.RemapFile + "'").Scan(&atsConfigLocation); err != nil {
+ if err := tx.QueryRow("SELECT value FROM parameter " +
+ "WHERE name = 'location'" +
+ " AND config_file = '" + RemapFile + "'").Scan(&atsConfigLocation); err != nil {
Review comment:
Goland can't highlight that properly? I expected more from them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org