You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/12 20:16:31 UTC

[GitHub] [tvm] csullivan commented on a diff in pull request #12364: [LowerVTCMAlloc] Move LowerVtcmAlloc to after StorageRewrite

csullivan commented on code in PR #12364:
URL: https://github.com/apache/tvm/pull/12364#discussion_r944812082


##########
src/tir/transforms/storage_rewrite.cc:
##########
@@ -583,8 +583,10 @@ class StoragePlanRewriter : public StmtExprMutator {
   };
 
   // Checks whether the storage_scope is especially tagged for a specific memory.
+  // Special memory is all combined into a single allocation.

Review Comment:
   I've verified that with the special tagged memory helper change we are getting correct behavior for aligned access in the cases that I mentioned to fail previously.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org