You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/11 12:56:05 UTC
[GitHub] [airflow-site] potiuk opened a new pull request, #613: Fix example_dags and system tests "source" links in documentation
potiuk opened a new pull request, #613:
URL: https://github.com/apache/airflow-site/pull/613
This is the result of running the scripts from
https://github.com/apache/airflow/pull/24389
Fixes: https://github.com/apache/airflow/issues/23632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] ashb commented on a diff in pull request #613: Fix example_dags and system tests "source" links in documentation
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #613:
URL: https://github.com/apache/airflow-site/pull/613#discussion_r896552299
##########
docs-archive/apache-airflow-providers-apache-beam/4.0.0/operators.html:
##########
@@ -616,7 +616,7 @@ <h1>Apache Beam Operators<a class="headerlink" href="#apache-beam-operators" tit
<div class="section" id="python-pipelines-with-directrunner">
<h2>Python Pipelines with DirectRunner<a class="headerlink" href="#python-pipelines-with-directrunner" title="Permalink to this headline">¶</a></h2>
<div class="example-block-wrapper compound">
-<p class="example-header example-header--with-button compound-first"><span class="example-title">tests/system/providers/apache/beam/example_python.py</span><a class="example-header-button viewcode-button reference internal" href="_modules/tests/system/providers/apache/beam/example_python.html"><span class="viewcode-link">[source]</span></a></p>
+<p class="example-header example-header--with-button compound-first"><span class="example-title">tests/system/providers/apache/beam/example_python.py</span><a class="example-header-button viewcode-button reference internal" href="https://github.com/apache/airflow/tree/providers-apache-beam/4.0.0/tests/system/providers/apache/beam/example_python.py" target="_blank"><span class="viewcode-link">[source]</span></a></p>
Review Comment:
Still some problems @potiuk https://airflow.apache.org/docs/apache-airflow-providers-apache-beam/4.0.0/_modules/tests/system/providers/apache/beam/example_python.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] ashb commented on a diff in pull request #613: Fix example_dags and system tests "source" links in documentation
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #613:
URL: https://github.com/apache/airflow-site/pull/613#discussion_r895503440
##########
docs-archive/apache-airflow-providers-airbyte/2.1.1/operators/airbyte.html:
##########
@@ -609,7 +609,7 @@ <h2>Using the Operator<a class="headerlink" href="#using-the-operator" title="Pe
return the <code class="docutils literal notranslate"><span class="pre">job_id</span></code> that should be pass to the AirbyteSensor.</p>
<p>An example using the synchronous way:</p>
<div class="example-block-wrapper docutils container">
-<p class="example-header example-header--with-button"><span class="example-title">airflow/providers/airbyte/example_dags/example_airbyte_trigger_job.py</span><a class="example-header-button viewcode-button reference internal" href="../_modules/airflow/providers/airbyte/example_dags/example_airbyte_trigger_job.html"><span class="viewcode-link">[source]</span></a></p>
+<p class="example-header example-header--with-button"><span class="example-title">airflow/providers/airbyte/example_dags/example_airbyte_trigger_job.py</span><a class="example-header-button viewcode-button reference internal" href="https://github.com/apache/airflow/tree/providers-airbyte/2.1.1/airflow/providers/airbyte/example_dags/example_airbyte_trigger_job.py" target="_blank"><span class="viewcode-link">[source]</span></a></p>
Review Comment:
But this file exists https://airflow.apache.org/docs/apache-airflow-providers-airbyte/2.1.1/_modules/airflow/providers/airbyte/example_dags/example_airbyte_trigger_job.html
Why aren't we linking to it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on a diff in pull request #613: Fix example_dags and system tests "source" links in documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #613:
URL: https://github.com/apache/airflow-site/pull/613#discussion_r896570804
##########
docs-archive/apache-airflow-providers-apache-beam/4.0.0/operators.html:
##########
@@ -616,7 +616,7 @@ <h1>Apache Beam Operators<a class="headerlink" href="#apache-beam-operators" tit
<div class="section" id="python-pipelines-with-directrunner">
<h2>Python Pipelines with DirectRunner<a class="headerlink" href="#python-pipelines-with-directrunner" title="Permalink to this headline">¶</a></h2>
<div class="example-block-wrapper compound">
-<p class="example-header example-header--with-button compound-first"><span class="example-title">tests/system/providers/apache/beam/example_python.py</span><a class="example-header-button viewcode-button reference internal" href="_modules/tests/system/providers/apache/beam/example_python.html"><span class="viewcode-link">[source]</span></a></p>
+<p class="example-header example-header--with-button compound-first"><span class="example-title">tests/system/providers/apache/beam/example_python.py</span><a class="example-header-button viewcode-button reference internal" href="https://github.com/apache/airflow/tree/providers-apache-beam/4.0.0/tests/system/providers/apache/beam/example_python.py" target="_blank"><span class="viewcode-link">[source]</span></a></p>
Review Comment:
Ah. Found it :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #613: Fix example_dags and system tests "source" links in documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #613:
URL: https://github.com/apache/airflow-site/pull/613#issuecomment-1154959124
BTW . As suspected, seems that the root cause was the autoapi upgrade https://github.com/apache/airflow/pull/20170 - the example links were missing since Airflow 2.2.4 where it was cherry-picked to and all providers affected were released after 9 Dec when it got merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #613: Fix example_dags and system tests "source" links in documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #613:
URL: https://github.com/apache/airflow-site/pull/613#issuecomment-1159804311
(and users get 404s )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #613: Fix example_dags and system tests "source" links in documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #613:
URL: https://github.com/apache/airflow-site/pull/613#issuecomment-1154952881
Looks like the list of affected files is "about right" this time
https://gist.github.com/potiuk/fca7dca641044a200a81b3ab236fba52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #613: Fix example_dags and system tests "source" links in documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #613:
URL: https://github.com/apache/airflow-site/pull/613#issuecomment-1154470040
Hey @ashb - re-rerun the scripts on base changes and airbyte is gone. I think it could be a remnant of the initial tests I've done. I'v optimized the scripts as well (less throttling possibility).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk merged pull request #613: Fix example_dags and system tests "source" links in documentation
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #613:
URL: https://github.com/apache/airflow-site/pull/613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on a diff in pull request #613: Fix example_dags and system tests "source" links in documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #613:
URL: https://github.com/apache/airflow-site/pull/613#discussion_r896565685
##########
docs-archive/apache-airflow-providers-apache-beam/4.0.0/operators.html:
##########
@@ -616,7 +616,7 @@ <h1>Apache Beam Operators<a class="headerlink" href="#apache-beam-operators" tit
<div class="section" id="python-pipelines-with-directrunner">
<h2>Python Pipelines with DirectRunner<a class="headerlink" href="#python-pipelines-with-directrunner" title="Permalink to this headline">¶</a></h2>
<div class="example-block-wrapper compound">
-<p class="example-header example-header--with-button compound-first"><span class="example-title">tests/system/providers/apache/beam/example_python.py</span><a class="example-header-button viewcode-button reference internal" href="_modules/tests/system/providers/apache/beam/example_python.html"><span class="viewcode-link">[source]</span></a></p>
+<p class="example-header example-header--with-button compound-first"><span class="example-title">tests/system/providers/apache/beam/example_python.py</span><a class="example-header-button viewcode-button reference internal" href="https://github.com/apache/airflow/tree/providers-apache-beam/4.0.0/tests/system/providers/apache/beam/example_python.py" target="_blank"><span class="viewcode-link">[source]</span></a></p>
Review Comment:
Ah. Strange this is the "latest" docs that should have been all ok :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on a diff in pull request #613: Fix example_dags and system tests "source" links in documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #613:
URL: https://github.com/apache/airflow-site/pull/613#discussion_r895583955
##########
docs-archive/apache-airflow-providers-airbyte/2.1.1/operators/airbyte.html:
##########
@@ -609,7 +609,7 @@ <h2>Using the Operator<a class="headerlink" href="#using-the-operator" title="Pe
return the <code class="docutils literal notranslate"><span class="pre">job_id</span></code> that should be pass to the AirbyteSensor.</p>
<p>An example using the synchronous way:</p>
<div class="example-block-wrapper docutils container">
-<p class="example-header example-header--with-button"><span class="example-title">airflow/providers/airbyte/example_dags/example_airbyte_trigger_job.py</span><a class="example-header-button viewcode-button reference internal" href="../_modules/airflow/providers/airbyte/example_dags/example_airbyte_trigger_job.html"><span class="viewcode-link">[source]</span></a></p>
+<p class="example-header example-header--with-button"><span class="example-title">airflow/providers/airbyte/example_dags/example_airbyte_trigger_job.py</span><a class="example-header-button viewcode-button reference internal" href="https://github.com/apache/airflow/tree/providers-airbyte/2.1.1/airflow/providers/airbyte/example_dags/example_airbyte_trigger_job.py" target="_blank"><span class="viewcode-link">[source]</span></a></p>
Review Comment:
I have to check my scripts in #24389. They should check if the file exist and only replace if it does not - it did that in vast majority of other cases, but maybe there is an error. That's why I also want to keep the scripts as reference in case we discover another similar issue in the future - then we wil be able to fix it, revert the commit and re-run the fixing script easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #613: Fix example_dags and system tests "source" links in documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #613:
URL: https://github.com/apache/airflow-site/pull/613#issuecomment-1159804250
Hey @ashb - shall we merge it ? Seems all issues are fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on a diff in pull request #613: Fix example_dags and system tests "source" links in documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #613:
URL: https://github.com/apache/airflow-site/pull/613#discussion_r896571118
##########
docs-archive/apache-airflow-providers-apache-beam/4.0.0/operators.html:
##########
@@ -616,7 +616,7 @@ <h1>Apache Beam Operators<a class="headerlink" href="#apache-beam-operators" tit
<div class="section" id="python-pipelines-with-directrunner">
<h2>Python Pipelines with DirectRunner<a class="headerlink" href="#python-pipelines-with-directrunner" title="Permalink to this headline">¶</a></h2>
<div class="example-block-wrapper compound">
-<p class="example-header example-header--with-button compound-first"><span class="example-title">tests/system/providers/apache/beam/example_python.py</span><a class="example-header-button viewcode-button reference internal" href="_modules/tests/system/providers/apache/beam/example_python.html"><span class="viewcode-link">[source]</span></a></p>
+<p class="example-header example-header--with-button compound-first"><span class="example-title">tests/system/providers/apache/beam/example_python.py</span><a class="example-header-button viewcode-button reference internal" href="https://github.com/apache/airflow/tree/providers-apache-beam/4.0.0/tests/system/providers/apache/beam/example_python.py" target="_blank"><span class="viewcode-link">[source]</span></a></p>
Review Comment:
Thanks. Good eyes. Fixing momentarily
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #613: Fix example_dags and system tests "source" links in documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #613:
URL: https://github.com/apache/airflow-site/pull/613#issuecomment-1154945267
Fix applied @ashb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on a diff in pull request #613: Fix example_dags and system tests "source" links in documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #613:
URL: https://github.com/apache/airflow-site/pull/613#discussion_r896578530
##########
docs-archive/apache-airflow-providers-apache-beam/4.0.0/operators.html:
##########
@@ -616,7 +616,7 @@ <h1>Apache Beam Operators<a class="headerlink" href="#apache-beam-operators" tit
<div class="section" id="python-pipelines-with-directrunner">
<h2>Python Pipelines with DirectRunner<a class="headerlink" href="#python-pipelines-with-directrunner" title="Permalink to this headline">¶</a></h2>
<div class="example-block-wrapper compound">
-<p class="example-header example-header--with-button compound-first"><span class="example-title">tests/system/providers/apache/beam/example_python.py</span><a class="example-header-button viewcode-button reference internal" href="_modules/tests/system/providers/apache/beam/example_python.html"><span class="viewcode-link">[source]</span></a></p>
+<p class="example-header example-header--with-button compound-first"><span class="example-title">tests/system/providers/apache/beam/example_python.py</span><a class="example-header-button viewcode-button reference internal" href="https://github.com/apache/airflow/tree/providers-apache-beam/4.0.0/tests/system/providers/apache/beam/example_python.py" target="_blank"><span class="viewcode-link">[source]</span></a></p>
Review Comment:
Fix here https://github.com/apache/airflow/pull/24389/commits/7858a23232e6fb193e1dc7d2f98b0cda5ca2d4ac :facepalm:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org