You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Ivan (JIRA)" <de...@myfaces.apache.org> on 2010/10/18 11:23:22 UTC
[jira] Created: (MYFACES-2944) Make those add*** methods public in
WebXml
Make those add*** methods public in WebXml
------------------------------------------
Key: MYFACES-2944
URL: https://issues.apache.org/jira/browse/MYFACES-2944
Project: MyFaces Core
Issue Type: Improvement
Components: General
Affects Versions: 2.0.2
Reporter: Ivan
In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
Is it possible to make those methods public, I did not see it will break anyting.
Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2944) Make those add*** methods public
in WebXml
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925758#action_12925758 ]
Jakob Korherr commented on MYFACES-2944:
----------------------------------------
Please also add this method to WebConfig:
protected boolean isFacesServlet(Class<?> servletClass) {
return FacesServlet.class.isAssignableFrom(servletClass) || DelegatedFacesServlet.class.isAssignableFrom(servletClass) || servletClass.getName().equals(getDelegateFacesServlet());
}
It will make the life of SPI providers easier!
Also: how are you planning to include the isOld() or the update() methods?
> Make those add*** methods public in WebXml
> ------------------------------------------
>
> Key: MYFACES-2944
> URL: https://issues.apache.org/jira/browse/MYFACES-2944
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
> Assignee: Jakob Korherr
> Fix For: 2.0.3-SNAPSHOT
>
> Attachments: MYFACES-2944-core.patch, MYFACES-2944-shared.patch, MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2944) Make those add*** methods public in
WebXml
Posted by "Ivan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan updated MYFACES-2944:
--------------------------
Status: Patch Available (was: Open)
> Make those add*** methods public in WebXml
> ------------------------------------------
>
> Key: MYFACES-2944
> URL: https://issues.apache.org/jira/browse/MYFACES-2944
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
> Attachments: MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2944) Make those add*** methods public
in WebXml
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924667#action_12924667 ]
Jakob Korherr commented on MYFACES-2944:
----------------------------------------
Talking to Leonardo we agreed that we won't revert the current solution, but build upon it.
Explanation of the current solution:
The geronimo team can provide the web.xml contents, so MyFaces does not have to parse the file itself. Talking to Ivan we agreed that an additional SPI - WebXmlProvider - is the best and cleanest solution for this problem. However there are some problems with making this an SPI:
1) WebXml is on shared and not directly in myfaces impl
2) WebXml provides a static method to get the current instance
Thus I came to the conclusion that the best way to do this is to put all the SPI classes for WebXml on shared, so that WebXml.getWebXml() and WebXml.update() can use the SPI to get the right instance and we do not have to deprecate (or remove) the methods of WebXml.
The decision about which methods should be kept on WebXml and which should be moved to WebXmlImpl was easy: Those which are needed in the code or by subclasses of WebXml are on WebXml and those which are just used to add content to it (like when parsing the file by the WebXmlParser) are moved to WebXmlImpl. In this way the service provider can implement the content-adding himself while not having to implement the methods only used by the SPI itself (like e.g. isOld() which provides the standard algorithm).
Also two new methods were added (isFacesServlet() and isFacesExtensionsFilter()), because of a request from the Geronimo team.
The advantage of the current solution is that the WebXml implementation and the WebXml parsing can easily be changed via the new SPI. Furthermore WebXml's methods were not changed and thus no changes were needed in the code that uses WebXml, even though getWebXml() now uses the SPI approach. The disadvantage of the current solution is that all SPI classes are on shared and thus not directly available in the spi package (but in shared_impl.spi).
Actually I really wanted to put the SPI classes directly into the spi package on impl, but as it turns out this isn't really possible, because of the fact that all the WebXml stuff is on shared and also because WebXml provides a static method which returns the current instance: getWebXml(). There is no way to support the current synthax and behavior of WebXml with an SPI that is entirely located in impl. However it would be possible if getWebXml() would be removed from the WebXml class, but this could mean a lot of changes is all shared-based projects (like e.g. tomahawk).
Suggestions for improvements are welcome!
> Make those add*** methods public in WebXml
> ------------------------------------------
>
> Key: MYFACES-2944
> URL: https://issues.apache.org/jira/browse/MYFACES-2944
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
> Assignee: Jakob Korherr
> Fix For: 2.0.3-SNAPSHOT
>
> Attachments: MYFACES-2944-core.patch, MYFACES-2944-shared.patch, MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2944) Make those add*** methods public
in WebXml
Posted by "Ivan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928095#action_12928095 ]
Ivan commented on MYFACES-2944:
-------------------------------
Hi, devs, it is really a great work, thanks. I will update the integration codes for Geronimo after the snapshot is ready, and will let you know if any problem.
> Make those add*** methods public in WebXml
> ------------------------------------------
>
> Key: MYFACES-2944
> URL: https://issues.apache.org/jira/browse/MYFACES-2944
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
> Assignee: Jakob Korherr
> Fix For: 2.0.3-SNAPSHOT
>
> Attachments: MYFACES-2944-core-2.patch, MYFACES-2944-core.patch, MYFACES-2944-shared-2.patch, MYFACES-2944-shared.patch, MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (MYFACES-2944) Make those add*** methods public in
WebXml
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe reopened MYFACES-2944:
-------------------------------------
The code is good, but I don't agree that move SpiUtils to shared and create a spi interface there should be the final solution.
Have spi interfaces everywhere in myfaces code makes things harder to understand and just put all existing methods on WebXml without think which one should be exposed or not is not a good strategy. LifecycleProvider is an exception because that code comes from jsf 1.x. I think the patch committed here should be reverted, so we can fix it properly.
Note that it is possible we need some changes to fix MYFACES-2952 on WebXml.
> Make those add*** methods public in WebXml
> ------------------------------------------
>
> Key: MYFACES-2944
> URL: https://issues.apache.org/jira/browse/MYFACES-2944
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
> Assignee: Jakob Korherr
> Fix For: 2.0.3-SNAPSHOT
>
> Attachments: MYFACES-2944-core.patch, MYFACES-2944-shared.patch, MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2944) Make those add*** methods public in
WebXml
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved MYFACES-2944.
-------------------------------------
Resolution: Fixed
Assignee: Leonardo Uribe (was: Jakob Korherr)
> Make those add*** methods public in WebXml
> ------------------------------------------
>
> Key: MYFACES-2944
> URL: https://issues.apache.org/jira/browse/MYFACES-2944
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
> Assignee: Leonardo Uribe
> Fix For: 2.0.3-SNAPSHOT
>
> Attachments: MYFACES-2944-core-2.patch, MYFACES-2944-core.patch, MYFACES-2944-shared-2.patch, MYFACES-2944-shared.patch, MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2944) Make those add*** methods public
in WebXml
Posted by "Ivan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923272#action_12923272 ]
Ivan commented on MYFACES-2944:
-------------------------------
It is better that you guys could help to work on it :-) I will try it soon.
thanks.
> Make those add*** methods public in WebXml
> ------------------------------------------
>
> Key: MYFACES-2944
> URL: https://issues.apache.org/jira/browse/MYFACES-2944
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
> Assignee: Jakob Korherr
> Attachments: MYFACES-2944-core.patch, MYFACES-2944-shared.patch, MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2944) Make those add*** methods public
in WebXml
Posted by "Ivan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922396#action_12922396 ]
Ivan commented on MYFACES-2944:
-------------------------------
That would be great, I am just thinking not to require too many changes to MyFaces ;-) So will you work on it ?
> Make those add*** methods public in WebXml
> ------------------------------------------
>
> Key: MYFACES-2944
> URL: https://issues.apache.org/jira/browse/MYFACES-2944
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
> Assignee: Jakob Korherr
> Attachments: MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2944) Make those add*** methods public
in WebXml
Posted by "Ivan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923364#action_12923364 ]
Ivan commented on MYFACES-2944:
-------------------------------
Hi, Jakob, the changes look perfect. If you could help to add two protected methods below, it will be better.
protected boolean isFacesServlet(Class<?> servletClass) {
return FacesServlet.class.isAssignableFrom(servletClass) || DelegatedFacesServlet.class.isAssignableFrom(servletClass) || servletClass.getName().equals(getDelegateFacesServlet());
}
protected boolean isFacesExtensionsFilter(Class<?> filterClass) {
return "org.apache.myfaces.component.html.util.ExtensionsFilter".equals(filterClass.getName()) || "org.apache.myfaces.webapp.filter.ExtensionsFilter".equals(filterClass.getName());
}
Many thanks :-)
> Make those add*** methods public in WebXml
> ------------------------------------------
>
> Key: MYFACES-2944
> URL: https://issues.apache.org/jira/browse/MYFACES-2944
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
> Assignee: Jakob Korherr
> Attachments: MYFACES-2944-core.patch, MYFACES-2944-shared.patch, MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2944) Make those add*** methods public
in WebXml
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928087#action_12928087 ]
Leonardo Uribe commented on MYFACES-2944:
-----------------------------------------
I have attached a patch for this feature. The idea is provide the following interface:
public abstract class WebConfigProvider
{
public abstract List<ServletMapping> getFacesServletMappings(ExternalContext externalContext);
public abstract boolean isErrorPagePresent(ExternalContext externalContext);
}
Based on the previous argumentation there is no need for any more methods, so I think in this part it is enough.
If no objections I'll commit this code soon.
> Make those add*** methods public in WebXml
> ------------------------------------------
>
> Key: MYFACES-2944
> URL: https://issues.apache.org/jira/browse/MYFACES-2944
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
> Assignee: Jakob Korherr
> Fix For: 2.0.3-SNAPSHOT
>
> Attachments: MYFACES-2944-core-2.patch, MYFACES-2944-core.patch, MYFACES-2944-shared-2.patch, MYFACES-2944-shared.patch, MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2944) Make those add*** methods public
in WebXml
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922233#action_12922233 ]
Jakob Korherr commented on MYFACES-2944:
----------------------------------------
Hi Ivan,
Thanks for the patch! However, I was thinking if it wouldn't be better to define an SPI to get the WebXml-Data and to make WebXml itself an interface. Then you guys would have a more convenient way to provide this data for MyFaces.
Is this ok for you, Ivan?
> Make those add*** methods public in WebXml
> ------------------------------------------
>
> Key: MYFACES-2944
> URL: https://issues.apache.org/jira/browse/MYFACES-2944
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
> Assignee: Jakob Korherr
> Attachments: MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2944) Make those add*** methods public
in WebXml
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923190#action_12923190 ]
Jakob Korherr commented on MYFACES-2944:
----------------------------------------
Ivan,
I just committed a (IMO more beautiful) SPI solution for creating the WebXml instance. Please take a look at WebXmlProviderFactory, WebXmlProvider and WebXml and tell me if this works for you. Thanks!
Jakob
> Make those add*** methods public in WebXml
> ------------------------------------------
>
> Key: MYFACES-2944
> URL: https://issues.apache.org/jira/browse/MYFACES-2944
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
> Assignee: Jakob Korherr
> Attachments: MYFACES-2944-core.patch, MYFACES-2944-shared.patch, MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2944) Make those add*** methods public
in WebXml
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925258#action_12925258 ]
Leonardo Uribe commented on MYFACES-2944:
-----------------------------------------
I investigated about why we need to provide a SPI interface to handle information
retrieved by WebXml interface and this is the results:
- In MyFaces core 1.1.x, this is used to calculate faces mapping (prefix/suffix)
and calculate the physical viewId (see 1.1.x JspViewHandlerImpl for details).
This happened on ViewHandler.renderView() and ViewHandler.getActionUrl()
- In JSF 1.2, the way to calculate faces mapping was specified:
see JSF 1.2 spec section 7.5.2. Since a web config param is used to pass that
information (javax.faces.DEFAULT_SUFFIX), there is no reason to parse web.xml
file, but MyFaces keeps doing it because nobody notice it before, and that
code is used by tomahawk to check if ExtensionsFilter is correctly configured.
- In Myfaces Core 2.0, two new uses were added:
1. org.apache.myfaces.renderkit.ErrorPageWriter.handleThrowable(FacesContext,
Throwable) now requires check if an error page is configured and if so
just save the view so it can handle there.
2. org.apache.myfaces.webapp.AbstractFacesInitializer.initFaces(ServletContext)
for check if there is a mapping configured and if it is not, do not initialize
MyFaces
Now the reasons becomes clear. If the need to parse web.xml file is by the previous
two points, it is clear we just need two methods to provide:
public abstract class WebConfig
{
public List<ServletMapping> getFacesServletMappings();
public boolean isErrorPagePresent();
}
We don't need to provide the methods used by tomahawk, because tomahawk will never
be able to retrieve that information, remember that myfaces package for shared is
org.apache.myfaces.shared_impl and tomahawk one is org.apache.myfaces.shared_tomahawk,
so it is just not possible without introduce a compile dependency with myfaces-impl
and that's just not viable.
All other methods are just implementation details, and should not be present on the
interface to provide.
My proposal is the default implementation just call WebXml related methods, and do not
use WebXml directly from ErrorPageWriter and AbstractFacesInitializer, instead use
WebConfig interface. ServletMapping interface will be copied to org.apache.myfaces.spi
package, because in that part we should prevent use shared interfaces (because shared
is private for myfaces).
I'll propose a patch for this one soon.
> Make those add*** methods public in WebXml
> ------------------------------------------
>
> Key: MYFACES-2944
> URL: https://issues.apache.org/jira/browse/MYFACES-2944
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
> Assignee: Jakob Korherr
> Fix For: 2.0.3-SNAPSHOT
>
> Attachments: MYFACES-2944-core.patch, MYFACES-2944-shared.patch, MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2944) Make those add*** methods public in
WebXml
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr resolved MYFACES-2944.
------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.3-SNAPSHOT
OK, great to hear!
I added the two methods you requested to WebXml, now everything should be in place for the WebXml-Geronimo integration :)
Resolving this one.
> Make those add*** methods public in WebXml
> ------------------------------------------
>
> Key: MYFACES-2944
> URL: https://issues.apache.org/jira/browse/MYFACES-2944
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.2
> Reporter: Ivan
> Assignee: Jakob Korherr
> Fix For: 2.0.3-SNAPSHOT
>
> Attachments: MYFACES-2944-core.patch, MYFACES-2944-shared.patch, MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope.
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.