You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/05/29 18:37:07 UTC
[GitHub] [mynewt-core] ccollins476ad opened a new pull request #2301: oic tcp4_adaptor: Don't loop if nothing to tx
ccollins476ad opened a new pull request #2301:
URL: https://github.com/apache/mynewt-core/pull/2301
This is a fix that I meant to include in the previous PR (https://github.com/apache/mynewt-core/pull/2300). Sorry for the confusion!
Prior to commit:
When a managed TCP connection had no pending transmits, the code would
enqueue another "tx" event. As a result, the "tx" event would always be
executing or enqueued!
Fix:
If a connection has no pending transmits, move on to the next
connection. Do not enqueue a "tx" event.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2301: oic tcp4_adaptor: Don't loop if nothing to tx
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2301:
URL: https://github.com/apache/mynewt-core/pull/2301#issuecomment-636127953
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2301: oic tcp4_adaptor: Don't loop if nothing to tx
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2301:
URL: https://github.com/apache/mynewt-core/pull/2301#issuecomment-636126091
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2301: oic tcp4_adaptor: Don't loop if nothing to tx
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2301:
URL: https://github.com/apache/mynewt-core/pull/2301#issuecomment-636126091
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] ccollins476ad commented on pull request #2301: oic tcp4_adaptor: Don't loop if nothing to tx
Posted by GitBox <gi...@apache.org>.
ccollins476ad commented on pull request #2301:
URL: https://github.com/apache/mynewt-core/pull/2301#issuecomment-636216588
Thanks @vrahane.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] ccollins476ad merged pull request #2301: oic tcp4_adaptor: Don't loop if nothing to tx
Posted by GitBox <gi...@apache.org>.
ccollins476ad merged pull request #2301:
URL: https://github.com/apache/mynewt-core/pull/2301
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org