You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/06/22 01:56:56 UTC

[GitHub] [mynewt-core] utzig commented on pull request #2294: mbedtls_aes_alt: add setkey for decyption, validate input, fix data type and return type

utzig commented on pull request #2294:
URL: https://github.com/apache/mynewt-core/pull/2294#issuecomment-647223559


   I am under the impression that `mbedtls_aes_setkey_enc` and `mbedtls_aes_setkey_dec` do the same thing, so maybe the code could be moved into a single function? Nice catch on the error return, the reason for only having `_enc` is that we only use CTR-mode for flash and image encryption and the CTR code in mbedTLS does not check return values!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org