[jira] [Commented] (LUCENE-9998) The param 'fis' in StoredFieldsWriter.finish(FieldInfos fis, int numDocs) is never used

["Adrien Grand (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362922#comment-17362922 ] 

Adrien Grand commented on LUCENE-9998:
--------------------------------------

I'm tempted to remove it as I can't think of a use-case for FieldInfos in {{#finish}}, and it would help simplify the API. Would you like to open a PR for this change?

> The param 'fis' in StoredFieldsWriter.finish(FieldInfos fis, int numDocs) is never used
> ---------------------------------------------------------------------------------------
>
>                 Key: LUCENE-9998
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9998
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/codecs
>    Affects Versions: 8.6.2
>            Reporter: kkewwei
>            Priority: Minor
>             Fix For: 8.6.2
>
>
> We can see the `FieldInfos fis` in StoredFieldsWriter.finish(FieldInfos fis, int numDocs) is never used. 
> The class has four subclasses: Lucene90CompressingStoredFieldsWriter,Lucene50CompressingStoredFieldsWriter,CrankyStoredFieldsWriter,SimpleTextStoredFieldsWriter.  the function `finish` in all four subclasses never use `fis`, if we could remove it from the function.
> The same situation with the function  `finish` in TermVectorsWriter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org