You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by PascalSchumacher <gi...@git.apache.org> on 2015/05/05 23:39:32 UTC
[GitHub] commons-lang pull request: @SuppressWarnings("deprecation") to joi...
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/84
@SuppressWarnings("deprecation") to joinWith, because it uses the
deprecated ObjectUtils.toString(Object) method (which is o.k. to use as
long as commons-lang3 does not require java 7 or greater)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang supress_compiler_warning
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
----
commit 823d2a0b957393f200fb33a87caff13fc231a78c
Author: Pascal Schumacher <pa...@gmx.net>
Date: 2015-05-05T21:38:35Z
@SuppressWarnings("deprecation") to joinWith, because it uses the
deprecated ObjectUtils.toString(Object) method (which is o.k. to use as
long as commons-lang3 does not require java 7 or greater)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: @SuppressWarnings("deprecation") to joi...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/84#issuecomment-99589501
[](https://coveralls.io/builds/2502815)
Coverage decreased (-0.0%) to 93.35% when pulling **82152f41ac8a727c2f0042bd555452dc2dda11b1 on PascalSchumacher:supress_compiler_warning** into **d6dd2b4cd4a337c5517952680c3714e5d08e9cb8 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: @SuppressWarnings("deprecation") to joi...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/84#issuecomment-99235241
[](https://coveralls.io/builds/2494346)
Coverage increased (+0.0%) to 93.35% when pulling **823d2a0b957393f200fb33a87caff13fc231a78c on PascalSchumacher:supress_compiler_warning** into **d6dd2b4cd4a337c5517952680c3714e5d08e9cb8 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: @SuppressWarnings("deprecation") to joi...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/84#discussion_r29735276
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -4196,7 +4196,8 @@ public static String join(final Iterable<?> iterable, final String separator) {
* @return the joined String.
* @throws java.lang.IllegalArgumentException if a null varargs is provided
*/
- public static String joinWith(final String separator, final Object... objects) {
+ @SuppressWarnings("deprecation")
--- End diff --
It's better to keep the scope of this annotation as small as possible. I'd rather assign the result of {{ObjectUtils.toString(iterator.next())}} and add the annotation there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: @SuppressWarnings("deprecation") to joi...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/84#issuecomment-99601310
[](https://coveralls.io/builds/2502757)
Coverage increased (+0.01%) to 93.36% when pulling **82152f41ac8a727c2f0042bd555452dc2dda11b1 on PascalSchumacher:supress_compiler_warning** into **d6dd2b4cd4a337c5517952680c3714e5d08e9cb8 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: @SuppressWarnings("deprecation") to joi...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/pull/84#issuecomment-99986254
Thanks for merging! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: @SuppressWarnings("deprecation") to joi...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/84#discussion_r29793834
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -4196,7 +4196,8 @@ public static String join(final Iterable<?> iterable, final String separator) {
* @return the joined String.
* @throws java.lang.IllegalArgumentException if a null varargs is provided
*/
- public static String joinWith(final String separator, final Object... objects) {
+ @SuppressWarnings("deprecation")
--- End diff --
good point
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: @SuppressWarnings("deprecation") to joi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---