You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Karl Pauls (Jira)" <ji...@apache.org> on 2020/10/29 09:29:00 UTC
[jira] [Resolved] (SLING-9823) Make analyzers report more context
about issues and make it possible to filter reports.
[ https://issues.apache.org/jira/browse/SLING-9823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Pauls resolved SLING-9823.
-------------------------------
Resolution: Fixed
Done in https://github.com/apache/sling-org-apache-sling-feature-analyser/commit/c07ea118a54999c4a38796ebf6c31c964dee13dc
I added report/get methods for warnings/errors for global/artifact/extension and added a report object to the analyses-metadata extension that can be used to set reporting to true/false for errors/warnings based on artifactid/featureid.
> Make analyzers report more context about issues and make it possible to filter reports.
> ---------------------------------------------------------------------------------------
>
> Key: SLING-9823
> URL: https://issues.apache.org/jira/browse/SLING-9823
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model Analyser
> Affects Versions: Feature Model Analyser 1.3.8
> Reporter: Karl Pauls
> Assignee: Karl Pauls
> Priority: Major
> Fix For: Feature Model Analyser 1.3.10
>
>
> Currently, an analyser task just reports a string (either as error or warning) - we should add new methods to AnalyserTaskContext for reporting error/warning.
> These methods should take an ArtifactId and a string or an extension name and a string (something like reportArtifactError(ArtifactId, String)...reportExtensionError(String, String) )
> This way the analysers can provide more context about a warning/error and we can display them later per artifact instead of a long list. With that we have three types of errors: global (just the string), per artifact id, per extension name - the analyser tasks could be updated to use the new methods where appropriate. Similar, we add new methods to AnalyserResult getting those three types of errors/warnings - and deprecate the two existing ones. They would be changed to return all errors/warnings - so everything would be compatible.
> The final piece is ignoring errors/warnings for certain artifacts. If we do the changes as mentioned above - the scanner/analyser does not need to know anything about whether something is ignored. We can handle this in the maven plugin.
> We have two options here: either we make this a configuration of the plugin - or we allow that metadata property is added to an artifact in the feature model telling the plugin to not report errors/warnings for this artifact.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)