You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/02/07 22:32:20 UTC

[Impala-ASF-CR] IMPALA-8147: part 1/2: make make *.sh redundant.

Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12368 )

Change subject: IMPALA-8147: part 1/2: make make_*.sh redundant.
......................................................................

IMPALA-8147: part 1/2: make make_*.sh redundant.

The logic in that file, which is mostly about constructing argument
lists for CMake and make, is moved to functions in buildall.sh.

A new option -release_and_debug is added to buildall.sh to build
both the debug and release builds. This is convenient for building
a binary Impala for distribution because you want to have both
sets of binaries available.

make*.sh are not yet removed in order to make the transition easier.

Testing:
Ran buildall.sh locally with -release_and_debug, confirmed that
all of the right binaries were generated.

Change-Id: I70e4f65712166348ca006bc68e1a1e18e853d3a0
---
M be/src/common/CMakeLists.txt
M bin/distcc/README.md
M bin/make_impala.sh
M buildall.sh
4 files changed, 90 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/12368/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I70e4f65712166348ca006bc68e1a1e18e853d3a0
Gerrit-Change-Number: 12368
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>