You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by Mark Struberg <st...@yahoo.de> on 2013/11/13 22:41:39 UTC
[VOTE] Release Apache OpenJPA-2.3.0
Hi!
I did prepare the OpenJPA-2.3.0 release yesterday and like to call a VOTE on it.
Just did some in depth testing with it on a few private projects and Romain and David did run TomEE tests (thus TCKed) on it.
The staging repository can be found here:
https://repository.apache.org/content/repositories/orgapacheopenjpa-117/
Here is the source release zip
https://repository.apache.org/content/repositories/orgapacheopenjpa-117/org/apache/openjpa/openjpa-parent/2.3.0/openjpa-parent-2.3.0-source-release.zip
sha1: e36ce9727ab4b37a31411ca723bb37b502a00d38
[+1] ship it!
[+0] meh, don't care
[-1] stop, becasue ${reason}
The VOTE is open for 72h.
Please note that I did not yet push the site. Will do this once the VOTE succeeds and the staging gets closed.
regards,
the OpenJPA Team
Re: [VOTE] Release Apache OpenJPA-2.3.0
Posted by Kevin Sutter <kw...@gmail.com>.
Hi Mark,
Thanks for doing the 2.3.0 release!
A few questions before I can cast a vote...
o Where are the release notes and such? I normally like to review the
release notes, change log, etc just to see what fixes and features were
included in the release. Normally, I find them in the openjpa-project
directory, but I don't see that content in your staging repo.
o Where is the javadoc available for review? I normally like to browse
the javadoc and verify the contents are appropriate (ie. not accidentally
include test case javadoc.)
o TCK results. So, the TomEE project ran the JPA 2.0 TCK? And, it was
clean?
Thanks, Mark.
On Wed, Nov 13, 2013 at 3:41 PM, Mark Struberg <st...@yahoo.de> wrote:
> Hi!
>
> I did prepare the OpenJPA-2.3.0 release yesterday and like to call a VOTE
> on it.
> Just did some in depth testing with it on a few private projects and
> Romain and David did run TomEE tests (thus TCKed) on it.
>
> The staging repository can be found here:
> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/
>
> Here is the source release zip
>
> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/org/apache/openjpa/openjpa-parent/2.3.0/openjpa-parent-2.3.0-source-release.zip
> sha1: e36ce9727ab4b37a31411ca723bb37b502a00d38
>
>
> [+1] ship it!
> [+0] meh, don't care
> [-1] stop, becasue ${reason}
>
> The VOTE is open for 72h.
>
>
> Please note that I did not yet push the site. Will do this once the VOTE
> succeeds and the staging gets closed.
>
>
>
> regards,
> the OpenJPA Team
>
Re: [VOTE] [RESULT] Release Apache OpenJPA-2.3.0
Posted by Mark Struberg <st...@yahoo.de>.
Hi!
The following votes have been cast
+1: Mark Struberg (non-binding), Romain Manni-Bucau (non-binding), Jean-Louis Monteiro (non-binding), David Blevins (non-binding), Albert Lee, Kevin Sutter, Rick Curtis
no +0
no -1 (Albert changed his -1 to +1 after I shipped the JavaDocs + we clarified the license year question).
Thus the VOTE has passed with 3 +1 and 4 non-binding +1.
Txs for all who voted and helped me with my first OpenJPA release.
Next steps: I will push the staging repo to maven.central. I also gonna create the site documentation and push it for review to my people account (in the next two days).
txs and LieGrue,
strub
>________________________________
> From: Mark Struberg <st...@yahoo.de>
>To: openjpa-dev <de...@openjpa.apache.org>
>Sent: Wednesday, 13 November 2013, 22:41
>Subject: [VOTE] Release Apache OpenJPA-2.3.0
>
>
>Hi!
>
>I did prepare the OpenJPA-2.3.0 release yesterday and like to call a VOTE on it.
>Just did some in depth testing with it on a few private projects and Romain and David did run TomEE tests (thus TCKed) on it.
>
>The staging repository can be found here:
>https://repository.apache.org/content/repositories/orgapacheopenjpa-117/
>
>Here is the source release zip
>https://repository.apache.org/content/repositories/orgapacheopenjpa-117/org/apache/openjpa/openjpa-parent/2.3.0/openjpa-parent-2.3.0-source-release.zip
>sha1: e36ce9727ab4b37a31411ca723bb37b502a00d38
>
>
>[+1] ship it!
>[+0] meh, don't care
>[-1] stop, becasue ${reason}
>
>The VOTE is open for 72h.
>
>
>Please note that I did not yet push the site. Will do this once the VOTE succeeds and the staging gets closed.
>
>
>
>regards,
>the OpenJPA Team
>
>
>
Re: [VOTE] Release Apache OpenJPA-2.3.0
Posted by Kevin Sutter <kw...@gmail.com>.
Hi Mark,
Thanks for the javadoc. I'll take a look shortly...
Question on the release process... Since we are over the 72 hour window,
do we need to cancel the first vote and start over? I don't know how picky
the process is in this regard, but I think we've had to do that in the past
with "slow votes"...
Thanks, Kevin
On Thu, Nov 21, 2013 at 8:00 AM, Mark Struberg <st...@yahoo.de> wrote:
>
>
> Hi folks!
>
> Sorry that it took me so long. I've now generated the JavaDocs from the
> tag and uploaded it to my people account
>
> http://people.apache.org/~struberg/openjpa/openjpa-parent-2.3.0-javadoc.jar
>
> txs and LieGrue,
> strub
>
>
>
>
>
> >________________________________
> > From: Mark Struberg <st...@yahoo.de>
> >To: Kevin Sutter <kw...@gmail.com>; "dev@openjpa.apache.org" <
> dev@openjpa.apache.org>
> >Sent: Monday, 18 November 2013, 17:02
> >Subject: Re: [VOTE] Release Apache OpenJPA-2.3.0
> >
> >
> >Sure I understand. Just being a bit under stress @ $dayjob. Will try to
> ship this in the evening.
> >
> >LieGrue,
> >strub
> >
> >
> >
> >
> >>________________________________
> >
> >> From: Kevin Sutter <kw...@gmail.com>
> >>To: dev@openjpa.apache.org; Mark Struberg <st...@yahoo.de>
> >>Sent: Monday, 18 November 2013, 15:35
> >>Subject: Re: [VOTE] Release Apache OpenJPA-2.3.0
> >>
> >>
> >>
> >>Hi Mark,
> >>I'm not entirely clear on what aspects are blockers for the vote or
> not... But, I really would like to have the javadoc available before I
> vote. I found an issue with the last OpenJPA release we did based on the
> contents of the javadoc. We decided to let it go with the expectation that
> it was cleared up for the next release. I want to verify that this
> particular issue was resolved and that we didn't introduce any others.
> Thanks for your patience.
> >>
> >>Kevin
> >>
> >>
> >>
> >>
> >>On Sun, Nov 17, 2013 at 11:54 PM, Mark Struberg <st...@yahoo.de>
> wrote:
> >>
> >>Hi Albert, all!
> >>>
> >>>
> >>>* As for the key: you can find my key in
> https://svn.apache.org/repos/asf/openwebbeans/trunk/KEYS
> >>>As the release is correctly signed this is not a blocker I think. Will
> of course add my key to openjpa as well now.
> >>>
> >>>* For the tag name: it's just a tag. Feel free to rename the tag. This
> does not affect the sources which is btw the only thing an ASF release
> constitutes of.
> >>>
> >>>
> >>>* Notice: yikes, how long did this not get fixed? Reminds me that we
> should go for 2014 immediately and do a check on all my projects in january
> again. Is this really a blocker? Not sure myself.
> >>>
> >>>
> >>>* OPENJPA-2335 sorry, my fault. Did reopen it, fixed it in branch and
> did not close it. Done now. It's in the release notes, so all is fine.
> >>>
> >>>* OPENJPA-2450 No idea why this got assigned as 'fixed in' 2.3.0.
> Removed it from there. This JIRA even got created after I started with the
> release process.
> >>>
> >>>
> >>>anything left?
> >>>
> >>>
> >>>
> >>>Gonna create the JavaDoc and try to push it from my office computer. If
> this doesn't work (firewall rules) then I try and push it in the afternoon.
> >>>
> >>>
> >>>No worries, if you feel there are still blocker in there then I try
> another respin within this week. In any case, thanks for the review, Albert!
> >>>
> >>>
> >>>
> >>>After the VOTE finally succeeds I gonna apply all my changes from
> branch to trunk.
> >>>
> >>>
> >>>txs and LieGrue,
> >>>strub
> >>>
> >>>
> >>>
> >>>
> >>>----- Original Message -----
> >>>> From: Albert Lee <al...@gmail.com>
> >>>> To: open-jpa-dev <de...@openjpa.apache.org>; Mark Struberg <
> struberg@yahoo.de>
> >>>> Cc:
> >>>> Sent: Sunday, 17 November 2013, 3:42
> >>>> Subject: Re: [VOTE] Release Apache OpenJPA-2.3.0
> >>>>
> >>>> Mark,
> >>>>
> >>>> Thanks you for putting up the release.
> >>>>
> >>>> -1 for the following observations:
> >>>>
> >>>> * I don't see your signature in svn.apache.org/repos/asf/openjpa/KEYSfile.
> >>>> See http://openjpa.apache.org/release-setup.html - Create a GPG key
> - step
> >>>> 4.
> >>>> * should the tags/openjpa-parent-2.3.0 be tags/2.3.0
> >>>> * From
> https://issues.apache.org/jira/browse/OPENJPA/fixforversion/12319463,
> >>>> there are still 1 JIRA (OPENJPA-2450) "in Progress" and 1 JIRA
> >>>> (OPENJPA-2335) in "Reopened" state. These need to be resolved.
> >>>> * In RELEASE-NOTES.html,
> >>>> ** "Notices" section, the copyright should be "Copyright
> >>>> 2006,2013 The
> >>>> Apache Software Foundation".
> >>>> ** End of the document, the copyright should be "Copyright (C)
> 2006,2012
> >>>> Apache Software Foundation. Licensed under Apache License 2.0."
> >>>> * openjpa-project/src/doc/manual/manual.html needs to update the
> copyright
> >>>> to 2013
> >>>> <title>Apache OpenJPA 2.3 User's Guide</title>
> >>>> <copyright>
> >>>> <year>2006-2013</year>
> >>>> <holder>The Apache Software Foundation</holder>
> >>>> * Can you post the javadoc url for viewing?
> >>>>
> >>>> Sorry for the -1 vote.
> >>>> Albert Lee.
> >>>>
> >>>>
> >>>> On Wed, Nov 13, 2013 at 3:41 PM, Mark Struberg <st...@yahoo.de>
> wrote:
> >>>>
> >>>>> Hi!
> >>>>>
> >>>>> I did prepare the OpenJPA-2.3.0 release yesterday and like to call
> a VOTE
> >>>>> on it.
> >>>>> Just did some in depth testing with it on a few private projects and
> >>>>> Romain and David did run TomEE tests (thus TCKed) on it.
> >>>>>
> >>>>> The staging repository can be found here:
> >>>>>
> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/
> >>>>>
> >>>>> Here is the source release zip
> >>>>>
> >>>>>
> >>>>
> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/org/apache/openjpa/openjpa-parent/2.3.0/openjpa-parent-2.3.0-source-release.zip
> >>>>> sha1: e36ce9727ab4b37a31411ca723bb37b502a00d38
> >>>>>
> >>>>>
> >>>>> [+1] ship it!
> >>>>> [+0] meh, don't care
> >>>>> [-1] stop, becasue ${reason}
> >>>>>
> >>>>> The VOTE is open for 72h.
> >>>>>
> >>>>>
> >>>>> Please note that I did not yet push the site. Will do this once the
> VOTE
> >>>>> succeeds and the staging gets closed.
> >>>>>
> >>>>>
> >>>>>
> >>>>> regards,
> >>>>> the OpenJPA Team
> >>>>>
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> Albert Lee.
> >>>>
> >>>
> >>
> >>
> >>
> >
> >
>
Re: [VOTE] Release Apache OpenJPA-2.3.0
Posted by Mark Struberg <st...@yahoo.de>.
Hi folks!
Sorry that it took me so long. I've now generated the JavaDocs from the tag and uploaded it to my people account
http://people.apache.org/~struberg/openjpa/openjpa-parent-2.3.0-javadoc.jar
txs and LieGrue,
strub
>________________________________
> From: Mark Struberg <st...@yahoo.de>
>To: Kevin Sutter <kw...@gmail.com>; "dev@openjpa.apache.org" <de...@openjpa.apache.org>
>Sent: Monday, 18 November 2013, 17:02
>Subject: Re: [VOTE] Release Apache OpenJPA-2.3.0
>
>
>Sure I understand. Just being a bit under stress @ $dayjob. Will try to ship this in the evening.
>
>LieGrue,
>strub
>
>
>
>
>>________________________________
>
>> From: Kevin Sutter <kw...@gmail.com>
>>To: dev@openjpa.apache.org; Mark Struberg <st...@yahoo.de>
>>Sent: Monday, 18 November 2013, 15:35
>>Subject: Re: [VOTE] Release Apache OpenJPA-2.3.0
>>
>>
>>
>>Hi Mark,
>>I'm not entirely clear on what aspects are blockers for the vote or not... But, I really would like to have the javadoc available before I vote. I found an issue with the last OpenJPA release we did based on the contents of the javadoc. We decided to let it go with the expectation that it was cleared up for the next release. I want to verify that this particular issue was resolved and that we didn't introduce any others. Thanks for your patience.
>>
>>Kevin
>>
>>
>>
>>
>>On Sun, Nov 17, 2013 at 11:54 PM, Mark Struberg <st...@yahoo.de> wrote:
>>
>>Hi Albert, all!
>>>
>>>
>>>* As for the key: you can find my key in https://svn.apache.org/repos/asf/openwebbeans/trunk/KEYS
>>>As the release is correctly signed this is not a blocker I think. Will of course add my key to openjpa as well now.
>>>
>>>* For the tag name: it's just a tag. Feel free to rename the tag. This does not affect the sources which is btw the only thing an ASF release constitutes of.
>>>
>>>
>>>* Notice: yikes, how long did this not get fixed? Reminds me that we should go for 2014 immediately and do a check on all my projects in january again. Is this really a blocker? Not sure myself.
>>>
>>>
>>>* OPENJPA-2335 sorry, my fault. Did reopen it, fixed it in branch and did not close it. Done now. It's in the release notes, so all is fine.
>>>
>>>* OPENJPA-2450 No idea why this got assigned as 'fixed in' 2.3.0. Removed it from there. This JIRA even got created after I started with the release process.
>>>
>>>
>>>anything left?
>>>
>>>
>>>
>>>Gonna create the JavaDoc and try to push it from my office computer. If this doesn't work (firewall rules) then I try and push it in the afternoon.
>>>
>>>
>>>No worries, if you feel there are still blocker in there then I try another respin within this week. In any case, thanks for the review, Albert!
>>>
>>>
>>>
>>>After the VOTE finally succeeds I gonna apply all my changes from branch to trunk.
>>>
>>>
>>>txs and LieGrue,
>>>strub
>>>
>>>
>>>
>>>
>>>----- Original Message -----
>>>> From: Albert Lee <al...@gmail.com>
>>>> To: open-jpa-dev <de...@openjpa.apache.org>; Mark Struberg <st...@yahoo.de>
>>>> Cc:
>>>> Sent: Sunday, 17 November 2013, 3:42
>>>> Subject: Re: [VOTE] Release Apache OpenJPA-2.3.0
>>>>
>>>> Mark,
>>>>
>>>> Thanks you for putting up the release.
>>>>
>>>> -1 for the following observations:
>>>>
>>>> * I don't see your signature in svn.apache.org/repos/asf/openjpa/KEYS file.
>>>> See http://openjpa.apache.org/release-setup.html - Create a GPG key - step
>>>> 4.
>>>> * should the tags/openjpa-parent-2.3.0 be tags/2.3.0
>>>> * From https://issues.apache.org/jira/browse/OPENJPA/fixforversion/12319463,
>>>> there are still 1 JIRA (OPENJPA-2450) "in Progress" and 1 JIRA
>>>> (OPENJPA-2335) in "Reopened" state. These need to be resolved.
>>>> * In RELEASE-NOTES.html,
>>>> ** "Notices" section, the copyright should be "Copyright
>>>> 2006,2013 The
>>>> Apache Software Foundation".
>>>> ** End of the document, the copyright should be "Copyright (C) 2006,2012
>>>> Apache Software Foundation. Licensed under Apache License 2.0."
>>>> * openjpa-project/src/doc/manual/manual.html needs to update the copyright
>>>> to 2013
>>>> <title>Apache OpenJPA 2.3 User's Guide</title>
>>>> <copyright>
>>>> <year>2006-2013</year>
>>>> <holder>The Apache Software Foundation</holder>
>>>> * Can you post the javadoc url for viewing?
>>>>
>>>> Sorry for the -1 vote.
>>>> Albert Lee.
>>>>
>>>>
>>>> On Wed, Nov 13, 2013 at 3:41 PM, Mark Struberg <st...@yahoo.de> wrote:
>>>>
>>>>> Hi!
>>>>>
>>>>> I did prepare the OpenJPA-2.3.0 release yesterday and like to call a VOTE
>>>>> on it.
>>>>> Just did some in depth testing with it on a few private projects and
>>>>> Romain and David did run TomEE tests (thus TCKed) on it.
>>>>>
>>>>> The staging repository can be found here:
>>>>> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/
>>>>>
>>>>> Here is the source release zip
>>>>>
>>>>>
>>>> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/org/apache/openjpa/openjpa-parent/2.3.0/openjpa-parent-2.3.0-source-release.zip
>>>>> sha1: e36ce9727ab4b37a31411ca723bb37b502a00d38
>>>>>
>>>>>
>>>>> [+1] ship it!
>>>>> [+0] meh, don't care
>>>>> [-1] stop, becasue ${reason}
>>>>>
>>>>> The VOTE is open for 72h.
>>>>>
>>>>>
>>>>> Please note that I did not yet push the site. Will do this once the VOTE
>>>>> succeeds and the staging gets closed.
>>>>>
>>>>>
>>>>>
>>>>> regards,
>>>>> the OpenJPA Team
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Albert Lee.
>>>>
>>>
>>
>>
>>
>
>
Re: [VOTE] Release Apache OpenJPA-2.3.0
Posted by Mark Struberg <st...@yahoo.de>.
Sure I understand. Just being a bit under stress @ $dayjob. Will try to ship this in the evening.
LieGrue,
strub
>________________________________
> From: Kevin Sutter <kw...@gmail.com>
>To: dev@openjpa.apache.org; Mark Struberg <st...@yahoo.de>
>Sent: Monday, 18 November 2013, 15:35
>Subject: Re: [VOTE] Release Apache OpenJPA-2.3.0
>
>
>
>Hi Mark,
>I'm not entirely clear on what aspects are blockers for the vote or not... But, I really would like to have the javadoc available before I vote. I found an issue with the last OpenJPA release we did based on the contents of the javadoc. We decided to let it go with the expectation that it was cleared up for the next release. I want to verify that this particular issue was resolved and that we didn't introduce any others. Thanks for your patience.
>
>Kevin
>
>
>
>
>On Sun, Nov 17, 2013 at 11:54 PM, Mark Struberg <st...@yahoo.de> wrote:
>
>Hi Albert, all!
>>
>>
>>* As for the key: you can find my key in https://svn.apache.org/repos/asf/openwebbeans/trunk/KEYS
>>As the release is correctly signed this is not a blocker I think. Will of course add my key to openjpa as well now.
>>
>>* For the tag name: it's just a tag. Feel free to rename the tag. This does not affect the sources which is btw the only thing an ASF release constitutes of.
>>
>>
>>* Notice: yikes, how long did this not get fixed? Reminds me that we should go for 2014 immediately and do a check on all my projects in january again. Is this really a blocker? Not sure myself.
>>
>>
>>* OPENJPA-2335 sorry, my fault. Did reopen it, fixed it in branch and did not close it. Done now. It's in the release notes, so all is fine.
>>
>>* OPENJPA-2450 No idea why this got assigned as 'fixed in' 2.3.0. Removed it from there. This JIRA even got created after I started with the release process.
>>
>>
>>anything left?
>>
>>
>>
>>Gonna create the JavaDoc and try to push it from my office computer. If this doesn't work (firewall rules) then I try and push it in the afternoon.
>>
>>
>>No worries, if you feel there are still blocker in there then I try another respin within this week. In any case, thanks for the review, Albert!
>>
>>
>>
>>After the VOTE finally succeeds I gonna apply all my changes from branch to trunk.
>>
>>
>>txs and LieGrue,
>>strub
>>
>>
>>
>>
>>----- Original Message -----
>>> From: Albert Lee <al...@gmail.com>
>>> To: open-jpa-dev <de...@openjpa.apache.org>; Mark Struberg <st...@yahoo.de>
>>> Cc:
>>> Sent: Sunday, 17 November 2013, 3:42
>>> Subject: Re: [VOTE] Release Apache OpenJPA-2.3.0
>>>
>>> Mark,
>>>
>>> Thanks you for putting up the release.
>>>
>>> -1 for the following observations:
>>>
>>> * I don't see your signature in svn.apache.org/repos/asf/openjpa/KEYS file.
>>> See http://openjpa.apache.org/release-setup.html - Create a GPG key - step
>>> 4.
>>> * should the tags/openjpa-parent-2.3.0 be tags/2.3.0
>>> * From https://issues.apache.org/jira/browse/OPENJPA/fixforversion/12319463,
>>> there are still 1 JIRA (OPENJPA-2450) "in Progress" and 1 JIRA
>>> (OPENJPA-2335) in "Reopened" state. These need to be resolved.
>>> * In RELEASE-NOTES.html,
>>> ** "Notices" section, the copyright should be "Copyright
>>> 2006,2013 The
>>> Apache Software Foundation".
>>> ** End of the document, the copyright should be "Copyright (C) 2006,2012
>>> Apache Software Foundation. Licensed under Apache License 2.0."
>>> * openjpa-project/src/doc/manual/manual.html needs to update the copyright
>>> to 2013
>>> <title>Apache OpenJPA 2.3 User's Guide</title>
>>> <copyright>
>>> <year>2006-2013</year>
>>> <holder>The Apache Software Foundation</holder>
>>> * Can you post the javadoc url for viewing?
>>>
>>> Sorry for the -1 vote.
>>> Albert Lee.
>>>
>>>
>>> On Wed, Nov 13, 2013 at 3:41 PM, Mark Struberg <st...@yahoo.de> wrote:
>>>
>>>> Hi!
>>>>
>>>> I did prepare the OpenJPA-2.3.0 release yesterday and like to call a VOTE
>>>> on it.
>>>> Just did some in depth testing with it on a few private projects and
>>>> Romain and David did run TomEE tests (thus TCKed) on it.
>>>>
>>>> The staging repository can be found here:
>>>> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/
>>>>
>>>> Here is the source release zip
>>>>
>>>>
>>> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/org/apache/openjpa/openjpa-parent/2.3.0/openjpa-parent-2.3.0-source-release.zip
>>>> sha1: e36ce9727ab4b37a31411ca723bb37b502a00d38
>>>>
>>>>
>>>> [+1] ship it!
>>>> [+0] meh, don't care
>>>> [-1] stop, becasue ${reason}
>>>>
>>>> The VOTE is open for 72h.
>>>>
>>>>
>>>> Please note that I did not yet push the site. Will do this once the VOTE
>>>> succeeds and the staging gets closed.
>>>>
>>>>
>>>>
>>>> regards,
>>>> the OpenJPA Team
>>>>
>>>
>>>
>>>
>>> --
>>> Albert Lee.
>>>
>>
>
>
>
Re: [VOTE] Release Apache OpenJPA-2.3.0
Posted by Kevin Sutter <kw...@gmail.com>.
Hi Mark,
I'm not entirely clear on what aspects are blockers for the vote or not...
But, I really would like to have the javadoc available before I vote. I
found an issue with the last OpenJPA release we did based on the contents
of the javadoc. We decided to let it go with the expectation that it was
cleared up for the next release. I want to verify that this particular
issue was resolved and that we didn't introduce any others. Thanks for
your patience.
Kevin
On Sun, Nov 17, 2013 at 11:54 PM, Mark Struberg <st...@yahoo.de> wrote:
> Hi Albert, all!
>
>
> * As for the key: you can find my key in
> https://svn.apache.org/repos/asf/openwebbeans/trunk/KEYS
> As the release is correctly signed this is not a blocker I think. Will of
> course add my key to openjpa as well now.
>
> * For the tag name: it's just a tag. Feel free to rename the tag. This
> does not affect the sources which is btw the only thing an ASF release
> constitutes of.
>
>
> * Notice: yikes, how long did this not get fixed? Reminds me that we
> should go for 2014 immediately and do a check on all my projects in january
> again. Is this really a blocker? Not sure myself.
>
>
> * OPENJPA-2335 sorry, my fault. Did reopen it, fixed it in branch and did
> not close it. Done now. It's in the release notes, so all is fine.
>
> * OPENJPA-2450 No idea why this got assigned as 'fixed in' 2.3.0. Removed
> it from there. This JIRA even got created after I started with the release
> process.
>
>
> anything left?
>
>
>
> Gonna create the JavaDoc and try to push it from my office computer. If
> this doesn't work (firewall rules) then I try and push it in the afternoon.
>
>
> No worries, if you feel there are still blocker in there then I try
> another respin within this week. In any case, thanks for the review, Albert!
>
>
>
> After the VOTE finally succeeds I gonna apply all my changes from branch
> to trunk.
>
>
> txs and LieGrue,
> strub
>
>
>
> ----- Original Message -----
> > From: Albert Lee <al...@gmail.com>
> > To: open-jpa-dev <de...@openjpa.apache.org>; Mark Struberg <
> struberg@yahoo.de>
> > Cc:
> > Sent: Sunday, 17 November 2013, 3:42
> > Subject: Re: [VOTE] Release Apache OpenJPA-2.3.0
> >
> > Mark,
> >
> > Thanks you for putting up the release.
> >
> > -1 for the following observations:
> >
> > * I don't see your signature in svn.apache.org/repos/asf/openjpa/KEYSfile.
> > See http://openjpa.apache.org/release-setup.html - Create a GPG key -
> step
> > 4.
> > * should the tags/openjpa-parent-2.3.0 be tags/2.3.0
> > * From
> https://issues.apache.org/jira/browse/OPENJPA/fixforversion/12319463,
> > there are still 1 JIRA (OPENJPA-2450) "in Progress" and 1 JIRA
> > (OPENJPA-2335) in "Reopened" state. These need to be resolved.
> > * In RELEASE-NOTES.html,
> > ** "Notices" section, the copyright should be "Copyright
> > 2006,2013 The
> > Apache Software Foundation".
> > ** End of the document, the copyright should be "Copyright (C) 2006,2012
> > Apache Software Foundation. Licensed under Apache License 2.0."
> > * openjpa-project/src/doc/manual/manual.html needs to update the
> copyright
> > to 2013
> > <title>Apache OpenJPA 2.3 User's Guide</title>
> > <copyright>
> > <year>2006-2013</year>
> > <holder>The Apache Software Foundation</holder>
> > * Can you post the javadoc url for viewing?
> >
> > Sorry for the -1 vote.
> > Albert Lee.
> >
> >
> > On Wed, Nov 13, 2013 at 3:41 PM, Mark Struberg <st...@yahoo.de>
> wrote:
> >
> >> Hi!
> >>
> >> I did prepare the OpenJPA-2.3.0 release yesterday and like to call a
> VOTE
> >> on it.
> >> Just did some in depth testing with it on a few private projects and
> >> Romain and David did run TomEE tests (thus TCKed) on it.
> >>
> >> The staging repository can be found here:
> >>
> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/
> >>
> >> Here is the source release zip
> >>
> >>
> >
> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/org/apache/openjpa/openjpa-parent/2.3.0/openjpa-parent-2.3.0-source-release.zip
> >> sha1: e36ce9727ab4b37a31411ca723bb37b502a00d38
> >>
> >>
> >> [+1] ship it!
> >> [+0] meh, don't care
> >> [-1] stop, becasue ${reason}
> >>
> >> The VOTE is open for 72h.
> >>
> >>
> >> Please note that I did not yet push the site. Will do this once the
> VOTE
> >> succeeds and the staging gets closed.
> >>
> >>
> >>
> >> regards,
> >> the OpenJPA Team
> >>
> >
> >
> >
> > --
> > Albert Lee.
> >
>
Re: [VOTE] Release Apache OpenJPA-2.3.0
Posted by Mark Struberg <st...@yahoo.de>.
Hi Albert, all!
* As for the key: you can find my key in https://svn.apache.org/repos/asf/openwebbeans/trunk/KEYS
As the release is correctly signed this is not a blocker I think. Will of course add my key to openjpa as well now.
* For the tag name: it's just a tag. Feel free to rename the tag. This does not affect the sources which is btw the only thing an ASF release constitutes of.
* Notice: yikes, how long did this not get fixed? Reminds me that we should go for 2014 immediately and do a check on all my projects in january again. Is this really a blocker? Not sure myself.
* OPENJPA-2335 sorry, my fault. Did reopen it, fixed it in branch and did not close it. Done now. It's in the release notes, so all is fine.
* OPENJPA-2450 No idea why this got assigned as 'fixed in' 2.3.0. Removed it from there. This JIRA even got created after I started with the release process.
anything left?
Gonna create the JavaDoc and try to push it from my office computer. If this doesn't work (firewall rules) then I try and push it in the afternoon.
No worries, if you feel there are still blocker in there then I try another respin within this week. In any case, thanks for the review, Albert!
After the VOTE finally succeeds I gonna apply all my changes from branch to trunk.
txs and LieGrue,
strub
----- Original Message -----
> From: Albert Lee <al...@gmail.com>
> To: open-jpa-dev <de...@openjpa.apache.org>; Mark Struberg <st...@yahoo.de>
> Cc:
> Sent: Sunday, 17 November 2013, 3:42
> Subject: Re: [VOTE] Release Apache OpenJPA-2.3.0
>
> Mark,
>
> Thanks you for putting up the release.
>
> -1 for the following observations:
>
> * I don't see your signature in svn.apache.org/repos/asf/openjpa/KEYS file.
> See http://openjpa.apache.org/release-setup.html - Create a GPG key - step
> 4.
> * should the tags/openjpa-parent-2.3.0 be tags/2.3.0
> * From https://issues.apache.org/jira/browse/OPENJPA/fixforversion/12319463,
> there are still 1 JIRA (OPENJPA-2450) "in Progress" and 1 JIRA
> (OPENJPA-2335) in "Reopened" state. These need to be resolved.
> * In RELEASE-NOTES.html,
> ** "Notices" section, the copyright should be "Copyright
> 2006,2013 The
> Apache Software Foundation".
> ** End of the document, the copyright should be "Copyright (C) 2006,2012
> Apache Software Foundation. Licensed under Apache License 2.0."
> * openjpa-project/src/doc/manual/manual.html needs to update the copyright
> to 2013
> <title>Apache OpenJPA 2.3 User's Guide</title>
> <copyright>
> <year>2006-2013</year>
> <holder>The Apache Software Foundation</holder>
> * Can you post the javadoc url for viewing?
>
> Sorry for the -1 vote.
> Albert Lee.
>
>
> On Wed, Nov 13, 2013 at 3:41 PM, Mark Struberg <st...@yahoo.de> wrote:
>
>> Hi!
>>
>> I did prepare the OpenJPA-2.3.0 release yesterday and like to call a VOTE
>> on it.
>> Just did some in depth testing with it on a few private projects and
>> Romain and David did run TomEE tests (thus TCKed) on it.
>>
>> The staging repository can be found here:
>> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/
>>
>> Here is the source release zip
>>
>>
> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/org/apache/openjpa/openjpa-parent/2.3.0/openjpa-parent-2.3.0-source-release.zip
>> sha1: e36ce9727ab4b37a31411ca723bb37b502a00d38
>>
>>
>> [+1] ship it!
>> [+0] meh, don't care
>> [-1] stop, becasue ${reason}
>>
>> The VOTE is open for 72h.
>>
>>
>> Please note that I did not yet push the site. Will do this once the VOTE
>> succeeds and the staging gets closed.
>>
>>
>>
>> regards,
>> the OpenJPA Team
>>
>
>
>
> --
> Albert Lee.
>
Re: [VOTE] Release Apache OpenJPA-2.3.0
Posted by David Blevins <da...@gmail.com>.
Thank you for taking a look!
On Nov 17, 2013, at 3:42 AM, Albert Lee <al...@gmail.com> wrote:
> Mark,
>
> Thanks you for putting up the release.
>
> -1 for the following observations:
>
> * I don't see your signature in svn.apache.org/repos/asf/openjpa/KEYS file.
> See http://openjpa.apache.org/release-setup.html - Create a GPG key - step
> 4.
> * should the tags/openjpa-parent-2.3.0 be tags/2.3.0
> * From https://issues.apache.org/jira/browse/OPENJPA/fixforversion/12319463,
> there are still 1 JIRA (OPENJPA-2450) "in Progress" and 1 JIRA
> (OPENJPA-2335) in "Reopened" state. These need to be resolved.
> * In RELEASE-NOTES.html,
> ** "Notices" section, the copyright should be "Copyright 2006,2013 The
> Apache Software Foundation".
> ** End of the document, the copyright should be "Copyright (C) 2006,2012
> Apache Software Foundation. Licensed under Apache License 2.0."
> * openjpa-project/src/doc/manual/manual.html needs to update the copyright
> to 2013
> <title>Apache OpenJPA 2.3 User's Guide</title>
> <copyright>
> <year>2006-2013</year>
> <holder>The Apache Software Foundation</holder>
> * Can you post the javadoc url for viewing?
>
> Sorry for the -1 vote.
> Albert Lee.
>
> On Wed, Nov 13, 2013 at 3:41 PM, Mark Struberg <st...@yahoo.de> wrote:
>
>> Hi!
>>
>> I did prepare the OpenJPA-2.3.0 release yesterday and like to call a VOTE
>> on it.
>> Just did some in depth testing with it on a few private projects and
>> Romain and David did run TomEE tests (thus TCKed) on it.
>>
>> The staging repository can be found here:
>> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/
>>
>> Here is the source release zip
>>
>> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/org/apache/openjpa/openjpa-parent/2.3.0/openjpa-parent-2.3.0-source-release.zip
>> sha1: e36ce9727ab4b37a31411ca723bb37b502a00d38
>>
>>
>> [+1] ship it!
>> [+0] meh, don't care
>> [-1] stop, becasue ${reason}
>>
>> The VOTE is open for 72h.
>>
>>
>> Please note that I did not yet push the site. Will do this once the VOTE
>> succeeds and the staging gets closed.
>>
>>
>>
>> regards,
>> the OpenJPA Team
>>
>
>
>
> --
> Albert Lee.
Re: [VOTE] Release Apache OpenJPA-2.3.0
Posted by Albert Lee <al...@gmail.com>.
Mark,
Thanks you for putting up the release.
-1 for the following observations:
* I don't see your signature in svn.apache.org/repos/asf/openjpa/KEYS file.
See http://openjpa.apache.org/release-setup.html - Create a GPG key - step
4.
* should the tags/openjpa-parent-2.3.0 be tags/2.3.0
* From https://issues.apache.org/jira/browse/OPENJPA/fixforversion/12319463,
there are still 1 JIRA (OPENJPA-2450) "in Progress" and 1 JIRA
(OPENJPA-2335) in "Reopened" state. These need to be resolved.
* In RELEASE-NOTES.html,
** "Notices" section, the copyright should be "Copyright 2006,2013 The
Apache Software Foundation".
** End of the document, the copyright should be "Copyright (C) 2006,2012
Apache Software Foundation. Licensed under Apache License 2.0."
* openjpa-project/src/doc/manual/manual.html needs to update the copyright
to 2013
<title>Apache OpenJPA 2.3 User's Guide</title>
<copyright>
<year>2006-2013</year>
<holder>The Apache Software Foundation</holder>
* Can you post the javadoc url for viewing?
Sorry for the -1 vote.
Albert Lee.
On Wed, Nov 13, 2013 at 3:41 PM, Mark Struberg <st...@yahoo.de> wrote:
> Hi!
>
> I did prepare the OpenJPA-2.3.0 release yesterday and like to call a VOTE
> on it.
> Just did some in depth testing with it on a few private projects and
> Romain and David did run TomEE tests (thus TCKed) on it.
>
> The staging repository can be found here:
> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/
>
> Here is the source release zip
>
> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/org/apache/openjpa/openjpa-parent/2.3.0/openjpa-parent-2.3.0-source-release.zip
> sha1: e36ce9727ab4b37a31411ca723bb37b502a00d38
>
>
> [+1] ship it!
> [+0] meh, don't care
> [-1] stop, becasue ${reason}
>
> The VOTE is open for 72h.
>
>
> Please note that I did not yet push the site. Will do this once the VOTE
> succeeds and the staging gets closed.
>
>
>
> regards,
> the OpenJPA Team
>
--
Albert Lee.