You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2018/05/30 03:34:00 UTC
[jira] [Commented] (HIVE-18823) Vectorization: introduce qtest for
SUM (IF/WHEN) with vectorization for ORC
[ https://issues.apache.org/jira/browse/HIVE-18823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494632#comment-16494632 ]
Hive QA commented on HIVE-18823:
--------------------------------
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 39s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 1m 9s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-11352/dev-support/hive-personality.sh |
| git revision | master / 0cb2a6c |
| modules | C: ql U: ql |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-11352/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Vectorization: introduce qtest for SUM (IF/WHEN) with vectorization for ORC
> ---------------------------------------------------------------------------
>
> Key: HIVE-18823
> URL: https://issues.apache.org/jira/browse/HIVE-18823
> Project: Hive
> Issue Type: Test
> Components: Hive
> Affects Versions: 2.3.0
> Reporter: Laszlo Bodor
> Assignee: Laszlo Bodor
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-18823.01.patch
>
>
> HIVE-16110 introduced some issues when using SUM aggregations with WHEN clause.
> As far as I can see, there is no separate qtests for validating that, vectorized_case is quite close, but not the same.
> The test case would be:
> {code:java}
> set hive.vectorized.execution.enabled=false;
> drop table if exists vectorization_sum_if_when_a;
> drop table if exists vectorization_sum_if_when_b;
> create table vectorization_sum_if_when_a (x int) stored as orc;
> insert into table vectorization_sum_if_when_a values (0), (1), (0), (NULL), (NULL), (NULL), (NULL), (NULL), (NULL), (NULL);
> create table vectorization_sum_if_when_b (x int) stored as orc;
> insert into table vectorization_sum_if_when_b select least(t1.x + t2.x + t3.x + t4.x, 1) from vectorization_sum_if_when_a t1, vectorization_sum_if_when_a t2, vectorization_sum_if_when_a t3, vectorization_sum_if_when_a t4;
> select count(*), x from vectorization_sum_if_when_b group by x;
> select sum(IF(x is null, 1, 0)), count(1) from vectorization_sum_if_when_b;
> select sum(IF(x=1, 1, 0)), count(1) from vectorization_sum_if_when_b;
> select sum((case WHEN x = 1 THEN 1 else 0 end)) from vectorization_sum_if_when_b;
> select sum((case WHEN x = 1 THEN 1 else 0 end)), sum((case WHEN x = 1 THEN 1 when x is null then 0 else 0 end)) from vectorization_sum_if_when_b;
> set hive.vectorized.execution.enabled=true;
> select sum(IF(x is null, 1, 0)), count(1) from vectorization_sum_if_when_b;
> select sum(IF(x=1, 1, 0)), count(1) from vectorization_sum_if_when_b;
> select sum((case WHEN x = 1 THEN 1 else 0 end)) from vectorization_sum_if_when_b;
> select sum((case WHEN x = 1 THEN 1 else 0 end)), sum((case WHEN x = 1 THEN 1 when x is null then 0 else 0 end)) from vectorization_sum_if_when_b;
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)