You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/03/20 02:04:37 UTC
[Impala-ASF-CR](2.x) [DOCS] Removed an unused keydef
Hello Alex Rodoni, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12804
to review the following change.
Change subject: [DOCS] Removed an unused keydef
......................................................................
[DOCS] Removed an unused keydef
Change-Id: I694adc75f8e1dbdf2913b18438f127f2d9dfd6b6
Reviewed-on: http://gerrit.cloudera.org:8080/10892
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/impala_keydefs.ditamap
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/12804/1
--
To view, visit http://gerrit.cloudera.org:8080/12804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I694adc75f8e1dbdf2913b18438f127f2d9dfd6b6
Gerrit-Change-Number: 12804
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](2.x) [DOCS] Removed an unused keydef
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12804 )
Change subject: [DOCS] Removed an unused keydef
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/282/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I694adc75f8e1dbdf2913b18438f127f2d9dfd6b6
Gerrit-Change-Number: 12804
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 02:04:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) [DOCS] Removed an unused keydef
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12804 )
Change subject: [DOCS] Removed an unused keydef
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I694adc75f8e1dbdf2913b18438f127f2d9dfd6b6
Gerrit-Change-Number: 12804
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 18:56:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) [DOCS] Removed an unused keydef
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12804 )
Change subject: [DOCS] Removed an unused keydef
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/282/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I694adc75f8e1dbdf2913b18438f127f2d9dfd6b6
Gerrit-Change-Number: 12804
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 02:22:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) [DOCS] Removed an unused keydef
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12804 )
Change subject: [DOCS] Removed an unused keydef
......................................................................
Patch Set 1:
This is a clean pick.
--
To view, visit http://gerrit.cloudera.org:8080/12804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I694adc75f8e1dbdf2913b18438f127f2d9dfd6b6
Gerrit-Change-Number: 12804
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 02:26:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) [DOCS] Removed an unused keydef
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12804 )
Change subject: [DOCS] Removed an unused keydef
......................................................................
[DOCS] Removed an unused keydef
Change-Id: I694adc75f8e1dbdf2913b18438f127f2d9dfd6b6
Reviewed-on: http://gerrit.cloudera.org:8080/10892
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/12804
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M docs/impala_keydefs.ditamap
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
Alex Rodoni: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I694adc75f8e1dbdf2913b18438f127f2d9dfd6b6
Gerrit-Change-Number: 12804
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR](2.x) [DOCS] Removed an unused keydef
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12804 )
Change subject: [DOCS] Removed an unused keydef
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I694adc75f8e1dbdf2913b18438f127f2d9dfd6b6
Gerrit-Change-Number: 12804
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 15:43:50 +0000
Gerrit-HasComments: No