You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/02/04 07:41:16 UTC
[GitHub] [buildstream] BuildStream-Migration-Bot opened a new pull request #1432: WIP: custom platform properties
BuildStream-Migration-Bot opened a new pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432
[See original merge request on GitLab](https://gitlab.com/BuildStream/buildstream/-/merge_requests/2100)
In GitLab by [[Gitlab user @tpollard]](https://gitlab.com/tpollard) on Nov 6, 2020, 16:55
This is related to https://gitlab.com/BuildStream/buildstream/-/issues/1313
In short, there are remote-exection usecases where server/worker implementations may incorporate custom/additional platform properties, or choose not to implement all/any of the 'optional' standard properties, as defined by the platform message lexicon:
https://github.com/bazelbuild/remote-apis/blob/master/build/bazel/remote/execution/v2/platform.md
- [x] Add tests (probably excessive running the full set of tests against multiple platform configurations?)
- [ ] Add validation type filtering (no nesting etc)
- [ ] Add support for multi value properties (i.e, ISA which needs support adding already even without this MR)
- [ ] Cache Key considerations (when changing default properties which have previously constituted `get_unique_key()` for the sandbox config)
This branch is being exercised with this remote-apis-testing MR https://gitlab.com/remote-apis-testing/remote-apis-testing/-/merge_requests/192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773102341
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773102489
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773104085
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773106543
In GitLab by [[Gitlab user @tpollard]](https://gitlab.com/tpollard) on Nov 25, 2020, 15:54
changed the description
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773103801
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773104449
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773105042
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773106785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773103010
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773102733
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773107204
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773102067
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773106936
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773106604
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773105814
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773103204
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773103743
In GitLab by [[Gitlab user @tpollard]](https://gitlab.com/tpollard) on Nov 11, 2020, 12:23
added 1 commit
<ul><li>6d463fe2 - Add some debug</li></ul>
[Compare with previous version](/BuildStream/buildstream/-/merge_requests/2100/diffs?diff_id=123888246&start_sha=82dc448a5d917de5b7ad34e50bd603e63ee69c24)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773104209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773103454
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773102067
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773105485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773105237
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773104811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1432: WIP: custom platform properties
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1432:
URL: https://github.com/apache/buildstream/pull/1432#issuecomment-773105961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org