[GitHub] [tvm] slyubomirsky opened a new pull request #7459: [Bugfix][Relay] Crash in match_exhaustion.cc when given an empty tuple pattern or constructor with no args

[GitBox <gi...@apache.org>]

slyubomirsky opened a new pull request #7459:
URL: https://github.com/apache/tvm/pull/7459


   This PR adds two test cases that previously caused match exhaustion to crash due to a bad decision in implementing `CartesianProduct`. These cases happen when an empty tuple or constructor with no fields (e.g., `Nil()`) needs to be expanded -- the Cartesian product used for wildcard expansion assumed that it would have at least one field to expand. This was silly of me, since there is exactly one expansion of zero fields: `{∅}`.
   
   I added a base case to `CartesianProduct` and regression tests.
   
   Please review @MarisaKirisame @jroesch. (Test case found through fuzzing.)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jroesch merged pull request #7459: [Bugfix][Relay] Crash in match_exhaustion.cc when given an empty tuple pattern or constructor with no args

[GitBox <gi...@apache.org>]

jroesch merged pull request #7459:
URL: https://github.com/apache/tvm/pull/7459


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org