You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/10 18:44:00 UTC
[jira] [Commented] (ARTEMIS-2199) PagingStore leak when deleting
queue
[ https://issues.apache.org/jira/browse/ARTEMIS-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715341#comment-16715341 ]
ASF GitHub Bot commented on ARTEMIS-2199:
-----------------------------------------
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2458
ARTEMIS-2199 PagingStore leak when deleting queue
When deleting a queue the JMSPostQueueDeletionCallback#callback will
invoke PostOfficeImpl#getBindingsForAddress which will *create* a
Bindings instance if one doesn't exist. This will trigger the creation
of a PagingStore instance which will be stored by the PagingManager
and may never be deleted. This is particularly problematic for use-cases
involving temporary JMS queues.
This change uses the lookupBindingsForAddress instead of
getBindingsForAddress which doesn't implicitly create a Bindings
instance.
This problem doesn't exist on the master branch as the
JMSPostQueueDeletionCallback no longer exists there.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2199
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2458.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2458
----
commit 6032fce45703d57be7e0a2542b443508674c406a
Author: Justin Bertram <jb...@...>
Date: 2018-12-10T18:13:37Z
ARTEMIS-2199 PagingStore leak when deleting queue
When deleting a queue the JMSPostQueueDeletionCallback#callback will
invoke PostOfficeImpl#getBindingsForAddress which will *create* a
Bindings instance if one doesn't exist. This will trigger the creation
of a PagingStore instance which will be stored by the PagingManager
and may never be deleted. This is particularly problematic for use-cases
involving temporary JMS queues.
This change uses the lookupBindingsForAddress instead of
getBindingsForAddress which doesn't implicitly create a Bindings
instance.
This problem doesn't exist on the master branch as the
JMSPostQueueDeletionCallback no longer exists there.
----
> PagingStore leak when deleting queue
> ------------------------------------
>
> Key: ARTEMIS-2199
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2199
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 1.5.6
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)