[GitHub] [incubator-doris] morningman commented on a change in pull request #7087: add replica num limit per tablet

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #7087:
URL: https://github.com/apache/incubator-doris/pull/7087#discussion_r747594797



##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
##########
@@ -190,8 +190,9 @@ private static Short analyzeReplicationNum(Map<String, String> properties, Strin
                 throw new AnalysisException(e.getMessage());
             }
 
-            if (replicationNum <= 0) {
-                throw new AnalysisException("Replication num should larger than 0. (suggested 3)");
+            if (replicationNum < Config.min_replication_num_per_tablet || replicationNum > Config.max_replication_num_per_tablet) {

Review comment:
       You may also need to modify the `analyzeReplicaAllocation()` method




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org