[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

["Jason Gerlowski (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276559#comment-17276559 ] 

Jason Gerlowski commented on SOLR-14920:
----------------------------------------

bq. I'm reluctant to do this to the Solr code base until ... we have some Solr-specific consensus

LUCENE-9564 where this was originally proposed had a healthy number of Solr guys (AB, Erick, David, Varun, Houston) voicing support.  (You can add my name to that list, though this is my first time chiming in.)  And neither LUCENE-9564 nor this ticket have brought out any detractors after 3-4 months.  It seems safe to say we've reached [lazy] consensus on this?

bq. we have some clue what this means for the reference impl.

The concern about {{tidy}} making life harder for the reference_impl branch (or any other large feature branch) is well taken.  How much should we avoid changes on master out of fear for the merge conflicts they'll cause on the reference_impl branch?  I'm of two mind's here: I don't want to make anyone's development difficult, but I also worry generally about the prudence of skipping improvements to master because of ref_impl conflicts.  Leaving improvements off of master looks a bit like throwing away the bird in the hand in favor of the two in the bush.  But I don't have strong convictions there.  In any case, I agree we need some consensus on that point particularly before inconveniencing the ref_impl branch.

But it's worth pointing out there's tons of code that the reference_impl _doesn't_ touch that we could start with.  There's a lot of safe places to start with this that don't require a consensus on the "ref_impl" discussion.

> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
>                 Key: SOLR-14920
>                 URL: https://issues.apache.org/jira/browse/SOLR-14920
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Erick Erickson
>            Priority: Major
>              Labels: codestyle, formatting
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr code base until after:
>  * we have some Solr-specific consensus
>  * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it over please feel free.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org