[GitHub] erisu opened a new pull request #377: Increase Code Coverage

[GitBox <gi...@apache.org>]

erisu opened a new pull request #377: Increase Code Coverage
URL: https://github.com/apache/cordova-ios/pull/377
 
 
   ### Platforms affected
   iOS
   
   ### What does this PR do?
   I wanted to help increase the code coverage for iOS so I wrote some additional tests around the missing area.
   
   I also:
   - Upgraded all of the testing and linting related dependencies.
   - I replaced the outdated istanbul code coverage npm package `istanbul@^0.4.2` with the new maintained Istanbul nyc package `nyc@^12.0.2`.
   
   This PR will require PR #375 and #376 to be merged before hand.
   - PR #375 deprecates Node 4. This PR contains ES6 usage (E.g let, const, etc) which is not supported in Node 4.
   - PR #376 fixes an issue with detecting the macOS version. This PR tests around the correction.
   
   ### What testing has been done on this change?
   **Note:** The links provided below contains results with the required PRs, mentioned above, merged.
   - https://travis-ci.org/erisu/cordova-ios/builds/395853027
   - https://ci.appveyor.com/project/erisu/cordova-ios
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [x] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org