You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "jiexray (via GitHub)" <gi...@apache.org> on 2023/08/29 02:16:35 UTC
[GitHub] [flink] jiexray commented on pull request #23305: [FLINK-32975][state/changelog] Enhance equal() for ChangelogMapState's iterator
jiexray commented on PR #23305:
URL: https://github.com/apache/flink/pull/23305#issuecomment-1696665750
@masteryhx Thank you for the review. I have added a new test in `ChangelogMapStateTest`. In the test, I try to assert the following:
```
state1.iterate().next() equals expected; // assert-1
state2.iterate().next() equals expected; // assert-2
state1.iterate().next() equals state2.iterate().next(); // assert-3
```
`assert-1` and `assert-2` are passed without the overwrite `equal()`. However, `assert-3` will fail without the overwrite `equal()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org