You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/11/21 02:19:39 UTC

[jira] Created: (ZOOKEEPER-586) c client does not compile under cygwin

c client does not compile under cygwin
--------------------------------------

                 Key: ZOOKEEPER-586
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
             Project: Zookeeper
          Issue Type: Bug
          Components: c client
    Affects Versions: 3.2.1
            Reporter: Patrick Hunt
             Fix For: 3.3.0
         Attachments: ZOOKEEPER-586.patch

the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-586:
------------------------------------

    Status: Patch Available  (was: Open)

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844783#action_12844783 ] 

Mahadev konar commented on ZOOKEEPER-586:
-----------------------------------------

I think a comment in the README saying 1.7 cygwin required to compile on windows for c library should be good enough. I dont think we will be able to officially support cygwin anytime in the near future.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844291#action_12844291 ] 

Mahadev konar commented on ZOOKEEPER-586:
-----------------------------------------

ben, can you update the jira with the test results from cygwin? Ill commit if it passes..... 

Also, pat do you want to open a jira to track fixing tests for cygwin later? you can assign it to 3.4... 

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-586:
------------------------------------

    Attachment: ZOOKEEPER-586.patch

uploading a patch that applies to trunk.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-586:
-----------------------------------

    Attachment: ZOOKEEPER-586.patch

this updated patch fixes (in addition to prev) the zkServer.sh to handle
slow java startup under cygwin/viruscheckers

Also fixes a problem with host name resolution on zookeeper_init (cygwin)

currently there are still 2 failures:

_st is failing testing watch notification (auto watch reset)

_mt is core dumping

(assumes that ZOOKEEPER-606 is already applied)

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-586:
------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

closing this as its checked in!

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844815#action_12844815 ] 

Patrick Hunt commented on ZOOKEEPER-586:
----------------------------------------

looks good, compiles cleanly now (well there's still that libtool issue, but nothing we can do onthat afaict)

ran cli_mt and cli_st against a running zk server and it worked fine.


> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844781#action_12844781 ] 

Benjamin Reed commented on ZOOKEEPER-586:
-----------------------------------------

that is my question. isn't it working on cygwin 1.7 good enough? btw the way, it compiles, but the tests still don't run cleanly.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844769#action_12844769 ] 

Patrick Hunt commented on ZOOKEEPER-586:
----------------------------------------

I got around the libtool problem by copying /usr/bin/libtool over the version generated by ./configure, that got me past that issue.

however now I see the following :

tests/LibCMocks.cc: In function `long int random()':
tests/LibCMocks.cc:170: error: new declaration `long int random()'
/usr/include/cygwin/stdlib.h:27: error: ambiguates old declaration `int random()
'
make[1]: *** [zktest_st-LibCMocks.o] Error 1

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-586:
-----------------------------------

    Status: Patch Available  (was: Open)

I'm submitting this so that we can get it into the code base. With this latest patch the client compiles under cygwin (1.5) however not all the tests run. I also tested the patch on ubuntu and it worked fine. I think we should commit as it allows the code to compile under cygwin, we can fix the cygwin tests later (also the issue of the new cygwin version, and what we will support going fwd).

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-586:
------------------------------------

    Status: Open  (was: Patch Available)

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-586:
-----------------------------------

    Status: Open  (was: Patch Available)

I'm seeing two issues on cygwin 15:

 src/zookeeper.c: In function `send_set_watches':
src/zookeeper.c:1286: warning: passing arg 2 of `collect_keys' from incompatible
 pointer type
src/zookeeper.c:1287: warning: passing arg 2 of `collect_keys' from incompatible
 pointer type
src/zookeeper.c:1288: warning: passing arg 2 of `collect_keys' from incompatible
 pointer type
make: *** [zookeeper.lo] Error 1

if you cast the second args to (int*) it fixes the issue.

The second problem is:
 ./libtool: eval: line 1005: syntax error near unexpected token `|'
./libtool: eval: line 1005: `/usr/bin/nm -B   ./.libs/libzkst.a ./.libs/libhasht
able.a |  | /usr/bin/sed -e '/^[BCDGRS][ ]/s/.*[ ]\([^ ]*\)/\1 DATA/;s/^.*[ ]__n
m__\([^ ]*\)[ ][^ ]*/\1 DATA/;/^I[ ]/d;/^[AITW][ ]/s/.* //' | sort | uniq > .lib

notice the | | btw the nm and sed calls, what's supposed to be here?


> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-586:
------------------------------------

    Status: Patch Available  (was: Open)

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844773#action_12844773 ] 

Benjamin Reed commented on ZOOKEEPER-586:
-----------------------------------------

yeah on cygwin 1.7 random returns a long int. which is what linux does as well. cygwin 1.5 returns an int. do we want to support both? it's making the code a bit ugly with all the ifdefs for a platform we really don't support.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-586:
------------------------------------

    Status: Patch Available  (was: Open)

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844265#action_12844265 ] 

Hadoop QA commented on ZOOKEEPER-586:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12436397/ZOOKEEPER-586.patch
  against trunk revision 921853.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 26 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/14/console

This message is automatically generated.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-586:
-----------------------------------

    Attachment: ZOOKEEPER-586.patch

Updated patch to latest code - fixed problem with pid variable.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844287#action_12844287 ] 

Hadoop QA commented on ZOOKEEPER-586:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12438553/ZOOKEEPER-586.patch
  against trunk revision 921853.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 26 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/15/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/15/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/15/console

This message is automatically generated.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836094#action_12836094 ] 

Hadoop QA commented on ZOOKEEPER-586:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12436397/ZOOKEEPER-586.patch
  against trunk revision 912052.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 26 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/73/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/73/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/73/console

This message is automatically generated.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-586:
------------------------------------

    Attachment: ZOOKEEPER-586.patch

made to work with 1.5

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt reassigned ZOOKEEPER-586:
--------------------------------------

    Assignee: Patrick Hunt

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845024#action_12845024 ] 

Hadoop QA commented on ZOOKEEPER-586:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12438671/ZOOKEEPER-586.patch
  against trunk revision 922759.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 29 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/23/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/23/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/23/console

This message is automatically generated.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845268#action_12845268 ] 

Hadoop QA commented on ZOOKEEPER-586:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12438671/ZOOKEEPER-586.patch
  against trunk revision 922759.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 29 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/81/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/81/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/81/console

This message is automatically generated.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846212#action_12846212 ] 

Hudson commented on ZOOKEEPER-586:
----------------------------------

Integrated in ZooKeeper-trunk #749 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/749/])
    . c client does not compile under cygwin


> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-586:
------------------------------------

    Attachment: ZOOKEEPER-586.patch

refreshed to work with trunk and cygwin 1.7. (we should check that it still compiles under earlier cygwin versions.)

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-586:
------------------------------------

    Status: Patch Available  (was: Open)

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844799#action_12844799 ] 

Patrick Hunt commented on ZOOKEEPER-586:
----------------------------------------

I don't think an extra ifdef is going to pull down the quality of that code much. 1.7 only recently came out. think of all the users still on 1.5. Doesn't seem like a big deal to me to add it.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-586:
------------------------------------

    Hadoop Flags: [Reviewed]

+1 great job pat.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-586:
------------------------------------

    Status: Patch Available  (was: Open)

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-586:
------------------------------------

    Status: Open  (was: Patch Available)

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-586:
------------------------------------

    Status: Patch Available  (was: Open)

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-586:
------------------------------------

    Status: Open  (was: Patch Available)

trying hudson to run with most current trunk!

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844820#action_12844820 ] 

Hadoop QA commented on ZOOKEEPER-586:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12438671/ZOOKEEPER-586.patch
  against trunk revision 922459.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 29 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/20/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/20/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/20/console

This message is automatically generated.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-586:
------------------------------------

    Status: Open  (was: Patch Available)

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844778#action_12844778 ] 

Patrick Hunt commented on ZOOKEEPER-586:
----------------------------------------

I think so. If we want it to work.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-586:
------------------------------------

    Status: Open  (was: Patch Available)

trying hudson again after ZOOKEEPER-121 was committed.

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-586:
-----------------------------------

    Attachment: ZOOKEEPER-586.patch

c client compiles with this patch but the tests fail

> c client does not compile under cygwin
> --------------------------------------
>
>                 Key: ZOOKEEPER-586
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-586.patch
>
>
> the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.