You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/20 21:07:13 UTC

[GitHub] [beam] KevinGG commented on a change in pull request #11174: [BEAM-7923] Pop failed transform in CombineGlobally

KevinGG commented on a change in pull request #11174: [BEAM-7923] Pop failed transform in CombineGlobally
URL: https://github.com/apache/beam/pull/11174#discussion_r395890026
 
 

 ##########
 File path: sdks/python/apache_beam/transforms/core.py
 ##########
 @@ -1811,6 +1811,8 @@ def add_input_types(transform):
       return view
     else:
       if pcoll.windowing.windowfn != GlobalWindows():
+        # Remove the broken transform when running into value error.
+        pcoll.pipeline.transforms_stack.pop()
 
 Review comment:
   Yes, agree with it! I'll make the change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services