You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2017/12/06 01:26:02 UTC

Review Request 64357: Updated the allocator to untrack allocations via a single code path.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64357/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Introduced a helper for untracking allocated resources in the
sorters.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.hpp 0622026858f7cff87ff0086b7be65f30c7555525 
  src/master/allocator/mesos/hierarchical.cpp d3485160df0c3c2fceba551371a5cade81bb4c71 


Diff: https://reviews.apache.org/r/64357/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu

Re: Review Request 64357: Updated the allocator to untrack allocations via a single code path.

Posted by Benjamin Mahler <bm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64357/#review193169
-----------------------------------------------------------


Fix it, then Ship it!





src/master/allocator/mesos/hierarchical.hpp
Lines 559 (patched)
<https://reviews.apache.org/r/64357/#comment271687>

    untrack resources that are no longer allocated?



src/master/allocator/mesos/hierarchical.cpp
Lines 2506-2512 (patched)
<https://reviews.apache.org/r/64357/#comment271690>

    ```
      // TODO(mzhu): Add a `CHECK(slaves.contains(slaveId));`
      // here once MESOS-621 is resolved. Ideally, `removeSlave()`
      // should unallocate resources in the framework sorters.
      // But currently, a slave is removed first via `removeSlave()`
      // and later a call to `recoverResources()` occurs to recover
      // the framework's resources.
    ```


- Benjamin Mahler


On Dec. 6, 2017, 1:26 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64357/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2017, 1:26 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced a helper for untracking allocated resources in the
> sorters.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 0622026858f7cff87ff0086b7be65f30c7555525 
>   src/master/allocator/mesos/hierarchical.cpp d3485160df0c3c2fceba551371a5cade81bb4c71 
> 
> 
> Diff: https://reviews.apache.org/r/64357/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>