You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gilles (JIRA)" <ji...@apache.org> on 2012/10/27 02:23:11 UTC
[jira] [Created] (MATH-883) "getSquareRoot" in "EigenDecomposition"
Gilles created MATH-883:
---------------------------
Summary: "getSquareRoot" in "EigenDecomposition"
Key: MATH-883
URL: https://issues.apache.org/jira/browse/MATH-883
Project: Commons Math
Issue Type: New Feature
Reporter: Gilles
Assignee: Gilles
Priority: Minor
Fix For: 3.1
I propose to add a method "getSquareRoot" in class "EigenDecomposition" (package "o.a.c.m.linear").
When assuming that the matrix is symmetric and positive definite, the implementation is trivial (see ["By diagonalisation"|http://en.wikipedia.org/wiki/Square_root_of_a_matrix]).
I would also suggest that the "isSymmetric" method be moved from "EigenDecomposition" to "MatrixUtils".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MATH-883) "getSquareRoot" in
"EigenDecomposition"
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles resolved MATH-883.
-------------------------
Resolution: Fixed
> "getSquareRoot" in "EigenDecomposition"
> ---------------------------------------
>
> Key: MATH-883
> URL: https://issues.apache.org/jira/browse/MATH-883
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: features
> Fix For: 3.1
>
> Attachments: MATH-883.diff
>
>
> I propose to add a method "getSquareRoot" in class "EigenDecomposition" (package "o.a.c.m.linear").
> When assuming that the matrix is symmetric and positive definite, the implementation is trivial (see ["By diagonalisation"|http://en.wikipedia.org/wiki/Square_root_of_a_matrix]).
> I would also suggest that the ["isSymmetric" method be moved from "EigenDecomposition" to "MatrixUtils"|MATH-884].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-883) "getSquareRoot" in
"EigenDecomposition"
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486550#comment-13486550 ]
Gilles commented on MATH-883:
-----------------------------
Code committed in revision 1403590.
> "getSquareRoot" in "EigenDecomposition"
> ---------------------------------------
>
> Key: MATH-883
> URL: https://issues.apache.org/jira/browse/MATH-883
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: features
> Fix For: 3.1
>
> Attachments: MATH-883.diff
>
>
> I propose to add a method "getSquareRoot" in class "EigenDecomposition" (package "o.a.c.m.linear").
> When assuming that the matrix is symmetric and positive definite, the implementation is trivial (see ["By diagonalisation"|http://en.wikipedia.org/wiki/Square_root_of_a_matrix]).
> I would also suggest that the ["isSymmetric" method be moved from "EigenDecomposition" to "MatrixUtils"|MATH-884].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MATH-883) "getSquareRoot" in "EigenDecomposition"
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles updated MATH-883:
------------------------
Description:
I propose to add a method "getSquareRoot" in class "EigenDecomposition" (package "o.a.c.m.linear").
When assuming that the matrix is symmetric and positive definite, the implementation is trivial (see ["By diagonalisation"|http://en.wikipedia.org/wiki/Square_root_of_a_matrix]).
I would also suggest that the ["isSymmetric" method be moved from "EigenDecomposition" to "MatrixUtils"|MATH-884].
was:
I propose to add a method "getSquareRoot" in class "EigenDecomposition" (package "o.a.c.m.linear").
When assuming that the matrix is symmetric and positive definite, the implementation is trivial (see ["By diagonalisation"|http://en.wikipedia.org/wiki/Square_root_of_a_matrix]).
I would also suggest that the "isSymmetric" method be moved from "EigenDecomposition" to "MatrixUtils".
> "getSquareRoot" in "EigenDecomposition"
> ---------------------------------------
>
> Key: MATH-883
> URL: https://issues.apache.org/jira/browse/MATH-883
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: features
> Fix For: 3.1
>
> Attachments: MATH-883.diff
>
>
> I propose to add a method "getSquareRoot" in class "EigenDecomposition" (package "o.a.c.m.linear").
> When assuming that the matrix is symmetric and positive definite, the implementation is trivial (see ["By diagonalisation"|http://en.wikipedia.org/wiki/Square_root_of_a_matrix]).
> I would also suggest that the ["isSymmetric" method be moved from "EigenDecomposition" to "MatrixUtils"|MATH-884].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-883) "getSquareRoot" in
"EigenDecomposition"
Posted by "Thomas Neidhart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485592#comment-13485592 ]
Thomas Neidhart commented on MATH-883:
--------------------------------------
There is a lack of unit tests ;-)
> "getSquareRoot" in "EigenDecomposition"
> ---------------------------------------
>
> Key: MATH-883
> URL: https://issues.apache.org/jira/browse/MATH-883
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: features
> Fix For: 3.1
>
> Attachments: MATH-883.patch
>
>
> I propose to add a method "getSquareRoot" in class "EigenDecomposition" (package "o.a.c.m.linear").
> When assuming that the matrix is symmetric and positive definite, the implementation is trivial (see ["By diagonalisation"|http://en.wikipedia.org/wiki/Square_root_of_a_matrix]).
> I would also suggest that the "isSymmetric" method be moved from "EigenDecomposition" to "MatrixUtils".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-883) "getSquareRoot" in
"EigenDecomposition"
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486541#comment-13486541 ]
Gilles commented on MATH-883:
-----------------------------
Yes.
> "getSquareRoot" in "EigenDecomposition"
> ---------------------------------------
>
> Key: MATH-883
> URL: https://issues.apache.org/jira/browse/MATH-883
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: features
> Fix For: 3.1
>
> Attachments: MATH-883.diff
>
>
> I propose to add a method "getSquareRoot" in class "EigenDecomposition" (package "o.a.c.m.linear").
> When assuming that the matrix is symmetric and positive definite, the implementation is trivial (see ["By diagonalisation"|http://en.wikipedia.org/wiki/Square_root_of_a_matrix]).
> I would also suggest that the ["isSymmetric" method be moved from "EigenDecomposition" to "MatrixUtils"|MATH-884].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MATH-883) "getSquareRoot" in "EigenDecomposition"
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles updated MATH-883:
------------------------
Attachment: MATH-883.diff
It was not my intention to not include tests! :)
> "getSquareRoot" in "EigenDecomposition"
> ---------------------------------------
>
> Key: MATH-883
> URL: https://issues.apache.org/jira/browse/MATH-883
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: features
> Fix For: 3.1
>
> Attachments: MATH-883.diff
>
>
> I propose to add a method "getSquareRoot" in class "EigenDecomposition" (package "o.a.c.m.linear").
> When assuming that the matrix is symmetric and positive definite, the implementation is trivial (see ["By diagonalisation"|http://en.wikipedia.org/wiki/Square_root_of_a_matrix]).
> I would also suggest that the "isSymmetric" method be moved from "EigenDecomposition" to "MatrixUtils".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-883) "getSquareRoot" in
"EigenDecomposition"
Posted by "Thomas Neidhart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486282#comment-13486282 ]
Thomas Neidhart commented on MATH-883:
--------------------------------------
Patch looks good, and I guess you will update the use of isSymmetric after resolving MATH-884?
> "getSquareRoot" in "EigenDecomposition"
> ---------------------------------------
>
> Key: MATH-883
> URL: https://issues.apache.org/jira/browse/MATH-883
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: features
> Fix For: 3.1
>
> Attachments: MATH-883.diff
>
>
> I propose to add a method "getSquareRoot" in class "EigenDecomposition" (package "o.a.c.m.linear").
> When assuming that the matrix is symmetric and positive definite, the implementation is trivial (see ["By diagonalisation"|http://en.wikipedia.org/wiki/Square_root_of_a_matrix]).
> I would also suggest that the ["isSymmetric" method be moved from "EigenDecomposition" to "MatrixUtils"|MATH-884].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MATH-883) "getSquareRoot" in "EigenDecomposition"
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles updated MATH-883:
------------------------
Attachment: MATH-883.patch
OK to apply the attached patch?
> "getSquareRoot" in "EigenDecomposition"
> ---------------------------------------
>
> Key: MATH-883
> URL: https://issues.apache.org/jira/browse/MATH-883
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: features
> Fix For: 3.1
>
> Attachments: MATH-883.patch
>
>
> I propose to add a method "getSquareRoot" in class "EigenDecomposition" (package "o.a.c.m.linear").
> When assuming that the matrix is symmetric and positive definite, the implementation is trivial (see ["By diagonalisation"|http://en.wikipedia.org/wiki/Square_root_of_a_matrix]).
> I would also suggest that the "isSymmetric" method be moved from "EigenDecomposition" to "MatrixUtils".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-883) "getSquareRoot" in
"EigenDecomposition"
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486558#comment-13486558 ]
Gilles commented on MATH-883:
-----------------------------
As of revision 1403591, the "isSymmetric" method from "MatrixUtils" is used.
> "getSquareRoot" in "EigenDecomposition"
> ---------------------------------------
>
> Key: MATH-883
> URL: https://issues.apache.org/jira/browse/MATH-883
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: features
> Fix For: 3.1
>
> Attachments: MATH-883.diff
>
>
> I propose to add a method "getSquareRoot" in class "EigenDecomposition" (package "o.a.c.m.linear").
> When assuming that the matrix is symmetric and positive definite, the implementation is trivial (see ["By diagonalisation"|http://en.wikipedia.org/wiki/Square_root_of_a_matrix]).
> I would also suggest that the ["isSymmetric" method be moved from "EigenDecomposition" to "MatrixUtils"|MATH-884].
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MATH-883) "getSquareRoot" in "EigenDecomposition"
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles updated MATH-883:
------------------------
Attachment: (was: MATH-883.patch)
> "getSquareRoot" in "EigenDecomposition"
> ---------------------------------------
>
> Key: MATH-883
> URL: https://issues.apache.org/jira/browse/MATH-883
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: features
> Fix For: 3.1
>
> Attachments: MATH-883.diff
>
>
> I propose to add a method "getSquareRoot" in class "EigenDecomposition" (package "o.a.c.m.linear").
> When assuming that the matrix is symmetric and positive definite, the implementation is trivial (see ["By diagonalisation"|http://en.wikipedia.org/wiki/Square_root_of_a_matrix]).
> I would also suggest that the "isSymmetric" method be moved from "EigenDecomposition" to "MatrixUtils".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira