[GitHub] [arrow] kou commented on a diff in pull request #34920: GH-34813: [C++] Improve GoogleTest detection

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #34920:
URL: https://github.com/apache/arrow/pull/34920#discussion_r1160202166


##########
cpp/CMakeLists.txt:
##########
@@ -839,8 +839,8 @@ if(NOT MSVC_TOOLCHAIN)
   list(APPEND ARROW_SHARED_LINK_LIBS ${CMAKE_DL_LIBS})
 endif()
 
-set(ARROW_TEST_LINK_TOOLCHAIN arrow::flatbuffers GTest::gtest_main GTest::gtest
-                              GTest::gmock)
+set(ARROW_TEST_LINK_TOOLCHAIN arrow::flatbuffers ${ARROW_GTEST_GTEST_MAIN}

Review Comment:
   We can use `add_library(ALIAS)` with CMake 3.11: https://cmake.org/cmake/help/latest/command/add_library.html#alias-libraries



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org