You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "linliu-code (via GitHub)" <gi...@apache.org> on 2024/11/21 01:53:49 UTC
[PR] [HUDI-8554] Use commit time ordering [hudi]
linliu-code opened a new pull request, #12304:
URL: https://github.com/apache/hudi/pull/12304
### Change Logs
Use commit_time_ordering.
### Impact
Just renaming.
### Risk level (write none, low medium or high below)
None.
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on code in PR #12304:
URL: https://github.com/apache/hudi/pull/12304#discussion_r1853082308
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -795,8 +795,8 @@ public static Triple<RecordMergeMode, String, String> inferCorrectMergingBehavio
// strategy and merge mode must be unset or align with overwrite
checkArgument(isNullOrEmpty(recordMergeStrategyId) || recordMergeStrategyId.equals(OVERWRITE_MERGE_STRATEGY_UUID),
"Record merge strategy cannot be set if a merge payload is used");
- checkArgument(recordMergeMode == null || recordMergeMode == OVERWRITE_WITH_LATEST, "Only overwrite with latest record merge mode can be used with overwrite payload");
- inferredRecordMergeMode = OVERWRITE_WITH_LATEST;
+ checkArgument(recordMergeMode == null || recordMergeMode == COMMIT_TIME_ORDERING, "Only overwrite with latest record merge mode can be used with overwrite payload");
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12304:
URL: https://github.com/apache/hudi/pull/12304#issuecomment-2492579534
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793",
"triggerID" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"triggerType" : "PUSH"
}, {
"hash" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1798",
"triggerID" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"triggerType" : "PUSH"
}, {
"hash" : "22c1d407bf90f39a780bb34526a24a8f5b7143b7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1830",
"triggerID" : "22c1d407bf90f39a780bb34526a24a8f5b7143b7",
"triggerType" : "PUSH"
}, {
"hash" : "df449c4edc43cd51f4532a86c64bcee078d6f804",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "df449c4edc43cd51f4532a86c64bcee078d6f804",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1798)
* 22c1d407bf90f39a780bb34526a24a8f5b7143b7 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1830)
* df449c4edc43cd51f4532a86c64bcee078d6f804 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12304:
URL: https://github.com/apache/hudi/pull/12304#issuecomment-2489907255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793",
"triggerID" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d42f8a570fab6d186ef2c9f8825e255346e0ade1 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12304:
URL: https://github.com/apache/hudi/pull/12304#issuecomment-2490154681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793",
"triggerID" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"triggerType" : "PUSH"
}, {
"hash" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1798",
"triggerID" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1798)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12304:
URL: https://github.com/apache/hudi/pull/12304#issuecomment-2492581682
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793",
"triggerID" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"triggerType" : "PUSH"
}, {
"hash" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1798",
"triggerID" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"triggerType" : "PUSH"
}, {
"hash" : "22c1d407bf90f39a780bb34526a24a8f5b7143b7",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1830",
"triggerID" : "22c1d407bf90f39a780bb34526a24a8f5b7143b7",
"triggerType" : "PUSH"
}, {
"hash" : "df449c4edc43cd51f4532a86c64bcee078d6f804",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "df449c4edc43cd51f4532a86c64bcee078d6f804",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22c1d407bf90f39a780bb34526a24a8f5b7143b7 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1830)
* df449c4edc43cd51f4532a86c64bcee078d6f804 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope merged PR #12304:
URL: https://github.com/apache/hudi/pull/12304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12304:
URL: https://github.com/apache/hudi/pull/12304#issuecomment-2490070109
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793",
"triggerID" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"triggerType" : "PUSH"
}, {
"hash" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d42f8a570fab6d186ef2c9f8825e255346e0ade1 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793)
* 5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12304:
URL: https://github.com/apache/hudi/pull/12304#issuecomment-2492568312
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793",
"triggerID" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"triggerType" : "PUSH"
}, {
"hash" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1798",
"triggerID" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"triggerType" : "PUSH"
}, {
"hash" : "22c1d407bf90f39a780bb34526a24a8f5b7143b7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1830",
"triggerID" : "22c1d407bf90f39a780bb34526a24a8f5b7143b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1798)
* 22c1d407bf90f39a780bb34526a24a8f5b7143b7 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1830)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12304:
URL: https://github.com/apache/hudi/pull/12304#issuecomment-2490071903
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793",
"triggerID" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"triggerType" : "PUSH"
}, {
"hash" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1798",
"triggerID" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d42f8a570fab6d186ef2c9f8825e255346e0ade1 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793)
* 5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1798)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12304:
URL: https://github.com/apache/hudi/pull/12304#issuecomment-2492635834
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793",
"triggerID" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"triggerType" : "PUSH"
}, {
"hash" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1798",
"triggerID" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"triggerType" : "PUSH"
}, {
"hash" : "22c1d407bf90f39a780bb34526a24a8f5b7143b7",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1830",
"triggerID" : "22c1d407bf90f39a780bb34526a24a8f5b7143b7",
"triggerType" : "PUSH"
}, {
"hash" : "df449c4edc43cd51f4532a86c64bcee078d6f804",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1832",
"triggerID" : "df449c4edc43cd51f4532a86c64bcee078d6f804",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22c1d407bf90f39a780bb34526a24a8f5b7143b7 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1830)
* df449c4edc43cd51f4532a86c64bcee078d6f804 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1832)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12304:
URL: https://github.com/apache/hudi/pull/12304#issuecomment-2492565605
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793",
"triggerID" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"triggerType" : "PUSH"
}, {
"hash" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1798",
"triggerID" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"triggerType" : "PUSH"
}, {
"hash" : "22c1d407bf90f39a780bb34526a24a8f5b7143b7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "22c1d407bf90f39a780bb34526a24a8f5b7143b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1798)
* 22c1d407bf90f39a780bb34526a24a8f5b7143b7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on PR #12304:
URL: https://github.com/apache/hudi/pull/12304#issuecomment-2492579212
Done. Grep the entire repo with:
`grep -r "overwrite_with_latest\|overwrite with latest" ./*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12304:
URL: https://github.com/apache/hudi/pull/12304#issuecomment-2489905445
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d42f8a570fab6d186ef2c9f8825e255346e0ade1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12304:
URL: https://github.com/apache/hudi/pull/12304#issuecomment-2489986038
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793",
"triggerID" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d42f8a570fab6d186ef2c9f8825e255346e0ade1 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex commented on code in PR #12304:
URL: https://github.com/apache/hudi/pull/12304#discussion_r1853060269
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -795,8 +795,8 @@ public static Triple<RecordMergeMode, String, String> inferCorrectMergingBehavio
// strategy and merge mode must be unset or align with overwrite
checkArgument(isNullOrEmpty(recordMergeStrategyId) || recordMergeStrategyId.equals(OVERWRITE_MERGE_STRATEGY_UUID),
"Record merge strategy cannot be set if a merge payload is used");
- checkArgument(recordMergeMode == null || recordMergeMode == OVERWRITE_WITH_LATEST, "Only overwrite with latest record merge mode can be used with overwrite payload");
- inferredRecordMergeMode = OVERWRITE_WITH_LATEST;
+ checkArgument(recordMergeMode == null || recordMergeMode == COMMIT_TIME_ORDERING, "Only overwrite with latest record merge mode can be used with overwrite payload");
Review Comment:
error messages need to be changed also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8554] Use COMMIT_TIME_ORDERING [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12304:
URL: https://github.com/apache/hudi/pull/12304#issuecomment-2492704453
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1793",
"triggerID" : "d42f8a570fab6d186ef2c9f8825e255346e0ade1",
"triggerType" : "PUSH"
}, {
"hash" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1798",
"triggerID" : "5c5ba1bccd3597e1921d9cff1ac5759dd99b6bc3",
"triggerType" : "PUSH"
}, {
"hash" : "22c1d407bf90f39a780bb34526a24a8f5b7143b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1830",
"triggerID" : "22c1d407bf90f39a780bb34526a24a8f5b7143b7",
"triggerType" : "PUSH"
}, {
"hash" : "df449c4edc43cd51f4532a86c64bcee078d6f804",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1832",
"triggerID" : "df449c4edc43cd51f4532a86c64bcee078d6f804",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* df449c4edc43cd51f4532a86c64bcee078d6f804 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1832)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org