[plc4x] branch develop updated: - Added some stricter rules regarding dependency convergence and including duplicate classes

[cd...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git


The following commit(s) were added to refs/heads/develop by this push:
     new a9e2f42  - Added some stricter rules regarding dependency convergence and including duplicate classes
a9e2f42 is described below

commit a9e2f420220d509a076d33413db8c5b6836cb2e2
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Mon Aug 12 16:21:41 2019 +0200

    - Added some stricter rules regarding dependency convergence and including duplicate classes
---
 pom.xml | 38 ++++++++++++++++++++++++++++++++++++--
 1 file changed, 36 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 51d3a23..e76bf26 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1614,9 +1614,8 @@
             <artifactId>maven-enforcer-plugin</artifactId>
             <version>3.0.0-M2</version> <!--$NO-MVN-MAN-VER$-->
             <executions>
-              <!-- Make sure no dependencies are used for which known vulnerabilities exist. -->
               <execution>
-                <id>sanity-checks</id>
+                <id>check-at-least-java-8</id>
                 <phase>validate</phase>
                 <goals>
                   <goal>enforce</goal>
@@ -1630,6 +1629,41 @@
                   </rules>
                 </configuration>
               </execution>
+              <!-- Ensure we're not mixing dependency versions -->
+              <execution>
+                <id>enforce-version-convergence</id>
+                <configuration>
+                  <rules>
+                    <dependencyConvergence/>
+                  </rules>
+                </configuration>
+                <goals>
+                  <goal>enforce</goal>
+                </goals>
+              </execution>
+              <!--
+                  Fails the build if classes are included from multiple
+                  artifacts and these are not identical.
+              -->
+              <execution>
+                  <id>enforce-ban-duplicate-classes</id>
+                  <goals>
+                      <goal>enforce</goal>
+                  </goals>
+                  <configuration>
+                      <rules>
+                          <banDuplicateClasses>
+                              <scopes>
+                                  <scope>compile</scope>
+                                  <scope>provided</scope>
+                              </scopes>
+                              <findAllDuplicates>true</findAllDuplicates>
+                              <ignoreWhenIdentical>true</ignoreWhenIdentical>
+                          </banDuplicateClasses>
+                      </rules>
+                      <fail>true</fail>
+                  </configuration>
+              </execution>
             </executions>
           </plugin>