You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/02/18 13:48:49 UTC

[GitHub] [mynewt-core] kasjer opened a new pull request #2777: hw/mcu/da1469x: Add support for both edges GPIO interrupt trigger

kasjer opened a new pull request #2777:
URL: https://github.com/apache/mynewt-core/pull/2777


   While hardware can be setup to detect only rising or falling
   edge it is possible to add HAL_GPIO_TRIG_BOTH support
   handled by software.
   
   This re-arms edge of interrupt in GPIO ISR to detect next change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] kasjer commented on pull request #2777: hw/mcu/da1469x: Add support for both edges GPIO interrupt trigger

Posted by GitBox <gi...@apache.org>.
kasjer commented on pull request #2777:
URL: https://github.com/apache/mynewt-core/pull/2777#issuecomment-1047225195


   @wes3 @andrzej-kaczmarek Thanks for the review.
   I was just trying to put it in words what Andy wrote so nicely.
   Event with hardware both edge detection it's not possible to detect all edges to to processing time limit.
   Real concern is not to leave detector in a state that slow change will be missed (that could happen if rising edge was expected but hi state was already present and transition to lo state could be missed).
   Right now I thing we should be ready for this. If rapid changes happen during the process of decision it may happen that edge will be detected but that should not spoil anything.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] kasjer edited a comment on pull request #2777: hw/mcu/da1469x: Add support for both edges GPIO interrupt trigger

Posted by GitBox <gi...@apache.org>.
kasjer edited a comment on pull request #2777:
URL: https://github.com/apache/mynewt-core/pull/2777#issuecomment-1047225195


   @wes3 @agross-korg Thanks for the review.
   I was just trying to put it in words what Andy wrote so nicely.
   Event with hardware both edge detection it's not possible to detect all edges to to processing time limit.
   Real concern is not to leave detector in a state that slow change will be missed (that could happen if rising edge was expected but hi state was already present and transition to lo state could be missed).
   Right now I thing we should be ready for this. If rapid changes happen during the process of decision it may happen that edge will be detected but that should not spoil anything.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] kasjer merged pull request #2777: hw/mcu/da1469x: Add support for both edges GPIO interrupt trigger

Posted by GitBox <gi...@apache.org>.
kasjer merged pull request #2777:
URL: https://github.com/apache/mynewt-core/pull/2777


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org