You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/01 08:47:32 UTC
[GitHub] [iceberg] hililiwei opened a new pull request, #6092: Flink: Add support for Flink 1.16
hililiwei opened a new pull request, #6092:
URL: https://github.com/apache/iceberg/pull/6092
To keep git history, please don't squash
* move flink/v1.15 to flink/v1.16
* copy flink/1.15 files from flink/1.16
* make flink 1.16 work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on a diff in pull request #6092: Flink: Add support for Flink 1.16
Posted by GitBox <gi...@apache.org>.
hililiwei commented on code in PR #6092:
URL: https://github.com/apache/iceberg/pull/6092#discussion_r1011546502
##########
.github/workflows/flink-ci.yml:
##########
@@ -93,7 +93,7 @@ jobs:
strategy:
matrix:
jvm: [8, 11]
- flink: ['1.13', '1.14', '1.15']
+ flink: ['1.13', '1.14', '1.15', '1.16']
Review Comment:
a new PR: #6103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on pull request #6092: Flink: Add support for Flink 1.16
Posted by GitBox <gi...@apache.org>.
hililiwei commented on PR #6092:
URL: https://github.com/apache/iceberg/pull/6092#issuecomment-1300002219
> > To keep git history, please don't squash
> >
> > * move flink/v1.15 to flink/v1.16
> > * copy flink/1.15 files from flink/1.16
> > * make flink 1.16 work
>
> @hililiwei you meant using the `Rebase and merge`, right?
Yeah, that's what I mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on a diff in pull request #6092: Flink: Add support for Flink 1.16
Posted by GitBox <gi...@apache.org>.
hililiwei commented on code in PR #6092:
URL: https://github.com/apache/iceberg/pull/6092#discussion_r1010490834
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java:
##########
@@ -602,53 +602,8 @@ public void testFilterPushDown2Literal() {
"Should not push down a filter", Expressions.alwaysTrue(), lastScanEvent.filter());
}
- /**
- * NaN is not supported by flink now, so we add the test case to assert the parse error, when we
- * upgrade the flink that supports NaN, we will delele the method, and add some test case to test
- * NaN.
- */
- @Test
- public void testSqlParseError() {
- String sqlParseErrorEqual =
- String.format("SELECT * FROM %s WHERE d = CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorEqual));
-
- String sqlParseErrorNotEqual =
- String.format("SELECT * FROM %s WHERE d <> CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorNotEqual));
-
- String sqlParseErrorGT =
- String.format("SELECT * FROM %s WHERE d > CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorGT));
-
- String sqlParseErrorLT =
- String.format("SELECT * FROM %s WHERE d < CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorLT));
-
- String sqlParseErrorGTE =
- String.format("SELECT * FROM %s WHERE d >= CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorGTE));
-
- String sqlParseErrorLTE =
- String.format("SELECT * FROM %s WHERE d <= CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorLTE));
+ @Test
+ public void testSqlParseNaN() {
+ // todo add some test case to test NaN
Review Comment:
TODO: After the introduction of 1.16, we need to adapt NaN.
From my preliminary tests, we need to make some changes in the filter section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on pull request #6092: Flink: Add support for Flink 1.16
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on PR #6092:
URL: https://github.com/apache/iceberg/pull/6092#issuecomment-1302310057
thanks @hililiwei for the contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on a diff in pull request #6092: Flink: Add support for Flink 1.16
Posted by GitBox <gi...@apache.org>.
hililiwei commented on code in PR #6092:
URL: https://github.com/apache/iceberg/pull/6092#discussion_r1010490834
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java:
##########
@@ -602,53 +602,8 @@ public void testFilterPushDown2Literal() {
"Should not push down a filter", Expressions.alwaysTrue(), lastScanEvent.filter());
}
- /**
- * NaN is not supported by flink now, so we add the test case to assert the parse error, when we
- * upgrade the flink that supports NaN, we will delele the method, and add some test case to test
- * NaN.
- */
- @Test
- public void testSqlParseError() {
- String sqlParseErrorEqual =
- String.format("SELECT * FROM %s WHERE d = CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorEqual));
-
- String sqlParseErrorNotEqual =
- String.format("SELECT * FROM %s WHERE d <> CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorNotEqual));
-
- String sqlParseErrorGT =
- String.format("SELECT * FROM %s WHERE d > CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorGT));
-
- String sqlParseErrorLT =
- String.format("SELECT * FROM %s WHERE d < CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorLT));
-
- String sqlParseErrorGTE =
- String.format("SELECT * FROM %s WHERE d >= CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorGTE));
-
- String sqlParseErrorLTE =
- String.format("SELECT * FROM %s WHERE d <= CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorLTE));
+ @Test
+ public void testSqlParseNaN() {
+ // todo add some test case to test NaN
Review Comment:
TODO: After the introduction of 1.16, we need to adapt NaN.
From my preliminary tests, we need to make some changes to the filter part of the flink connector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6092: Flink: Add support for Flink 1.16
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #6092:
URL: https://github.com/apache/iceberg/pull/6092#discussion_r1010939194
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java:
##########
@@ -602,53 +602,8 @@ public void testFilterPushDown2Literal() {
"Should not push down a filter", Expressions.alwaysTrue(), lastScanEvent.filter());
}
- /**
- * NaN is not supported by flink now, so we add the test case to assert the parse error, when we
- * upgrade the flink that supports NaN, we will delele the method, and add some test case to test
- * NaN.
- */
- @Test
- public void testSqlParseError() {
- String sqlParseErrorEqual =
- String.format("SELECT * FROM %s WHERE d = CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorEqual));
-
- String sqlParseErrorNotEqual =
- String.format("SELECT * FROM %s WHERE d <> CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorNotEqual));
-
- String sqlParseErrorGT =
- String.format("SELECT * FROM %s WHERE d > CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorGT));
-
- String sqlParseErrorLT =
- String.format("SELECT * FROM %s WHERE d < CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorLT));
-
- String sqlParseErrorGTE =
- String.format("SELECT * FROM %s WHERE d >= CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorGTE));
-
- String sqlParseErrorLTE =
- String.format("SELECT * FROM %s WHERE d <= CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorLTE));
+ @Test
+ public void testSqlParseNaN() {
+ // todo add some test case to test NaN
Review Comment:
do you plan to fix it in this PR or will do it in a follow-up PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on a diff in pull request #6092: Flink: Add support for Flink 1.16
Posted by GitBox <gi...@apache.org>.
hililiwei commented on code in PR #6092:
URL: https://github.com/apache/iceberg/pull/6092#discussion_r1011465412
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java:
##########
@@ -602,53 +602,8 @@ public void testFilterPushDown2Literal() {
"Should not push down a filter", Expressions.alwaysTrue(), lastScanEvent.filter());
}
- /**
- * NaN is not supported by flink now, so we add the test case to assert the parse error, when we
- * upgrade the flink that supports NaN, we will delele the method, and add some test case to test
- * NaN.
- */
- @Test
- public void testSqlParseError() {
- String sqlParseErrorEqual =
- String.format("SELECT * FROM %s WHERE d = CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorEqual));
-
- String sqlParseErrorNotEqual =
- String.format("SELECT * FROM %s WHERE d <> CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorNotEqual));
-
- String sqlParseErrorGT =
- String.format("SELECT * FROM %s WHERE d > CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorGT));
-
- String sqlParseErrorLT =
- String.format("SELECT * FROM %s WHERE d < CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorLT));
-
- String sqlParseErrorGTE =
- String.format("SELECT * FROM %s WHERE d >= CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorGTE));
-
- String sqlParseErrorLTE =
- String.format("SELECT * FROM %s WHERE d <= CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorLTE));
+ @Test
+ public void testSqlParseNaN() {
+ // todo add some test case to test NaN
Review Comment:
I plan to do it in a follow-up PR, which is already in development. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on pull request #6092: Flink: Add support for Flink 1.16
Posted by GitBox <gi...@apache.org>.
hililiwei commented on PR #6092:
URL: https://github.com/apache/iceberg/pull/6092#issuecomment-1301674985
> LGTM
>
> @hililiwei since we are going to use `rebase and merge`, can you update the commit messages so that each contains the `Flink: ` prefix.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6092: Flink: Add support for Flink 1.16
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #6092:
URL: https://github.com/apache/iceberg/pull/6092#discussion_r1011971787
##########
.github/workflows/flink-ci.yml:
##########
@@ -93,7 +93,7 @@ jobs:
strategy:
matrix:
jvm: [8, 11]
- flink: ['1.13', '1.14', '1.15']
+ flink: ['1.13', '1.14', '1.15', '1.16']
Review Comment:
merged. please rebase this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu merged pull request #6092: Flink: Add support for Flink 1.16
Posted by GitBox <gi...@apache.org>.
stevenzwu merged PR #6092:
URL: https://github.com/apache/iceberg/pull/6092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6092: Flink: Add support for Flink 1.16
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #6092:
URL: https://github.com/apache/iceberg/pull/6092#discussion_r1010939977
##########
.github/workflows/flink-ci.yml:
##########
@@ -93,7 +93,7 @@ jobs:
strategy:
matrix:
jvm: [8, 11]
- flink: ['1.13', '1.14', '1.15']
+ flink: ['1.13', '1.14', '1.15', '1.16']
Review Comment:
can you create a PR to remove 1.13? I think we typically remove the old version first before merging a new version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on pull request #6092: Flink: Add support for Flink 1.16
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on PR #6092:
URL: https://github.com/apache/iceberg/pull/6092#issuecomment-1299281575
> To keep git history, please don't squash
>
> * move flink/v1.15 to flink/v1.16
> * copy flink/1.15 files from flink/1.16
> * make flink 1.16 work
@hililiwei you meant using the `Rebase and merge`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on a diff in pull request #6092: Flink: Add support for Flink 1.16
Posted by GitBox <gi...@apache.org>.
hililiwei commented on code in PR #6092:
URL: https://github.com/apache/iceberg/pull/6092#discussion_r1010490834
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java:
##########
@@ -602,53 +602,8 @@ public void testFilterPushDown2Literal() {
"Should not push down a filter", Expressions.alwaysTrue(), lastScanEvent.filter());
}
- /**
- * NaN is not supported by flink now, so we add the test case to assert the parse error, when we
- * upgrade the flink that supports NaN, we will delele the method, and add some test case to test
- * NaN.
- */
- @Test
- public void testSqlParseError() {
- String sqlParseErrorEqual =
- String.format("SELECT * FROM %s WHERE d = CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorEqual));
-
- String sqlParseErrorNotEqual =
- String.format("SELECT * FROM %s WHERE d <> CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorNotEqual));
-
- String sqlParseErrorGT =
- String.format("SELECT * FROM %s WHERE d > CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorGT));
-
- String sqlParseErrorLT =
- String.format("SELECT * FROM %s WHERE d < CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorLT));
-
- String sqlParseErrorGTE =
- String.format("SELECT * FROM %s WHERE d >= CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorGTE));
-
- String sqlParseErrorLTE =
- String.format("SELECT * FROM %s WHERE d <= CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorLTE));
+ @Test
+ public void testSqlParseNaN() {
+ // todo add some test case to test NaN
Review Comment:
TODO: After the introduction of 1.16, we need to adapt NaN.
From my preliminary tests, we need to make some changes in the flink source/sink filter section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org