[GitHub] [pinot] timsants commented on a diff in pull request #8856: BUGFIX: Adding util for getting URL from InstanceConfig

[GitBox <gi...@apache.org>]

timsants commented on code in PR #8856:
URL: https://github.com/apache/pinot/pull/8856#discussion_r918545812


##########
pinot-common/src/main/java/org/apache/pinot/common/helix/ExtraInstanceConfig.java:
##########
@@ -44,4 +45,31 @@ public String getTlsPort() {
   public void setTlsPort(String tlsPort) {
     _proxy.getRecord().setSimpleField(PinotInstanceConfigProperty.PINOT_TLS_PORT.toString(), tlsPort);
   }
+
+  /**
+   * Returns an instance URL from the InstanceConfig. Will set the appropriate protocol and port. Returns null
+   * if the URL cannot be constructed.
+   */
+  public String getComponentUrl() {

Review Comment:
   InstanceConfig is a class used by all the Pinot components (broker, server, controller, minion). So this util was supposed to serve the purpose of getting the REST API URL for any of those components. So I can update the method name/javadoc to be clearer.
   
   Thanks for pointing out that the server should route to "adminPort" instead of "port". Is this the case only for calls to server?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org