You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "dcais (via GitHub)" <gi...@apache.org> on 2023/03/27 13:36:03 UTC
[GitHub] [rocketmq] dcais opened a new pull request, #6487: [ISSUE #6448] Fix SystemClock.now() is affected by NTP time synchronization, which can cause inaccuracies in the result of isOSPageCacheBusy()
dcais opened a new pull request, #6487:
URL: https://github.com/apache/rocketmq/pull/6487
**Make sure set the target branch to `develop`**
## Fix SystemClock.now() is affected by NTP time synchronization, which can cause inaccuracies in the result of isOSPageCacheBusy()
fix #6448
## Brief changelog
1. Replace elapsed time calculation by System.nanoTime()
## Verifying this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6487: [ISSUE #6448] Fix SystemClock.now() is affected by NTP time synchronization, which can cause inaccuracies in the result of isOSPageCacheBusy()
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6487:
URL: https://github.com/apache/rocketmq/pull/6487#issuecomment-1486040209
## [Codecov](https://codecov.io/gh/apache/rocketmq/pull/6487?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6487](https://codecov.io/gh/apache/rocketmq/pull/6487?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c768e2) into [develop](https://codecov.io/gh/apache/rocketmq/commit/9b90b5b70ab284b56e16ffceff565f10af33b0c1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b90b5b) will **decrease** coverage by `0.02%`.
> The diff coverage is `31.74%`.
```diff
@@ Coverage Diff @@
## develop #6487 +/- ##
=============================================
- Coverage 43.19% 43.18% -0.02%
+ Complexity 9018 9013 -5
=============================================
Files 1106 1106
Lines 78224 78261 +37
Branches 10198 10199 +1
=============================================
+ Hits 33791 33794 +3
- Misses 40197 40232 +35
+ Partials 4236 4235 -1
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/6487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/rocketmq/broker/BrokerController.java](https://codecov.io/gh/apache/rocketmq/pull/6487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | `43.67% <0.00%> (ø)` | |
| [...n/java/org/apache/rocketmq/common/SystemClock.java](https://codecov.io/gh/apache/rocketmq/pull/6487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vU3lzdGVtQ2xvY2suamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...org/apache/rocketmq/namesrv/NamesrvController.java](https://codecov.io/gh/apache/rocketmq/pull/6487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9OYW1lc3J2Q29udHJvbGxlci5qYXZh) | `65.25% <0.00%> (ø)` | |
| [...ocketmq/proxy/remoting/RemotingProtocolServer.java](https://codecov.io/gh/apache/rocketmq/pull/6487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3JlbW90aW5nL1JlbW90aW5nUHJvdG9jb2xTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/6487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `46.82% <0.00%> (+0.02%)` | :arrow_up: |
| [...va/org/apache/rocketmq/store/kv/CompactionLog.java](https://codecov.io/gh/apache/rocketmq/pull/6487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2t2L0NvbXBhY3Rpb25Mb2cuamF2YQ==) | `21.09% <0.00%> (-0.22%)` | :arrow_down: |
| [...rg/apache/rocketmq/remoting/netty/RequestTask.java](https://codecov.io/gh/apache/rocketmq/pull/6487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L1JlcXVlc3RUYXNrLmphdmE=) | `24.39% <20.00%> (-0.61%)` | :arrow_down: |
| [...q/tieredstore/provider/posix/PosixFileSegment.java](https://codecov.io/gh/apache/rocketmq/pull/6487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL3Byb3ZpZGVyL3Bvc2l4L1Bvc2l4RmlsZVNlZ21lbnQuamF2YQ==) | `60.17% <37.50%> (ø)` | |
| [...main/java/org/apache/rocketmq/store/CommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/6487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `64.79% <40.00%> (-0.45%)` | :arrow_down: |
| [...che/rocketmq/broker/latency/BrokerFastFailure.java](https://codecov.io/gh/apache/rocketmq/pull/6487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbGF0ZW5jeS9Ccm9rZXJGYXN0RmFpbHVyZS5qYXZh) | `63.76% <50.00%> (+1.44%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/rocketmq/pull/6487?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [19 files with indirect coverage changes](https://codecov.io/gh/apache/rocketmq/pull/6487/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-code-scanning[bot] commented on pull request #6487: [ISSUE #6448] Fix SystemClock.now() is affected by NTP time synchronization, which can cause inaccuracies in the result of isOSPageCacheBusy()
Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on PR #6487:
URL: https://github.com/apache/rocketmq/pull/6487#issuecomment-1486030211
You have successfully added a new CodeQL configuration `.github/workflows/codeql_analysis.yml:CodeQL-Build`. As part of the setup process, we have scanned this repository and found 9 existing alerts. Please check the repository [Security tab](/apache/rocketmq/security/code-scanning?query=pr%3A6487+tool%3ACodeQL+is%3Aopen) to see all alerts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] dcais closed pull request #6487: [ISSUE #6448] Fix SystemClock.now() is affected by NTP time synchronization, which can cause inaccuracies in the result of isOSPageCacheBusy()
Posted by "dcais (via GitHub)" <gi...@apache.org>.
dcais closed pull request #6487: [ISSUE #6448] Fix SystemClock.now() is affected by NTP time synchronization, which can cause inaccuracies in the result of isOSPageCacheBusy()
URL: https://github.com/apache/rocketmq/pull/6487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org