You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/13 21:16:01 UTC

[GitHub] [beam] fernando-wizeline opened a new pull request, #21838: [21826]- beam post commit java sickbay fails

fernando-wizeline opened a new pull request, #21838:
URL: https://github.com/apache/beam/pull/21838

   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] asf-ci commented on pull request #21838: [21826]- beam post commit java sickbay fails

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21838:
URL: https://github.com/apache/beam/pull/21838#issuecomment-1154447338

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] robertwb commented on pull request #21838: [21826] - beam post commit java sickbay fails

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #21838:
URL: https://github.com/apache/beam/pull/21838#issuecomment-1185848465

   Looks like there are conflicts that need to be resolved now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem commented on a diff in pull request #21838: [21826] - beam post commit java sickbay fails

Posted by GitBox <gi...@apache.org>.
pabloem commented on code in PR #21838:
URL: https://github.com/apache/beam/pull/21838#discussion_r900488531


##########
build.gradle.kts:
##########
@@ -210,7 +210,8 @@ tasks.register("javaPostCommit") {
 tasks.register("javaPostCommitSickbay") {
   dependsOn(":runners:samza:validatesRunnerSickbay")
   dependsOn(":runners:flink:validatesRunnerSickbay")
-  dependsOn(":runners:spark:validatesRunnerSickbay")
+  dependsOn(":runners:spark:3:validatesRunnerSickbay")
+  dependsOn(":runners:spark:2:validatesRunnerSickbay")

Review Comment:
   Can you also add what we have in the above javaPostCommit?
   
   These, but the sickbay versions:
   
   ```
     dependsOn(":sdks:java:extensions:google-cloud-platform-core:postCommit")
     dependsOn(":sdks:java:extensions:zetasketch:postCommit")
     dependsOn(":sdks:java:io:google-cloud-platform:postCommit")
     dependsOn(":sdks:java:io:amazon-web-services:integrationTest")
     dependsOn(":sdks:java:io:amazon-web-services2:integrationTest")
     dependsOn(":sdks:java:extensions:ml:postCommit")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] asf-ci commented on pull request #21838: [21826]- beam post commit java sickbay fails

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21838:
URL: https://github.com/apache/beam/pull/21838#issuecomment-1154447326

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #21838: [21826] - beam post commit java sickbay fails

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21838:
URL: https://github.com/apache/beam/pull/21838#issuecomment-1471892886

   This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #21838: [21826] - beam post commit java sickbay fails

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21838:
URL: https://github.com/apache/beam/pull/21838#issuecomment-1460102306

   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] asf-ci commented on pull request #21838: [21826]- beam post commit java sickbay fails

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21838:
URL: https://github.com/apache/beam/pull/21838#issuecomment-1154447323

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] asf-ci commented on pull request #21838: [21826]- beam post commit java sickbay fails

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21838:
URL: https://github.com/apache/beam/pull/21838#issuecomment-1154447332

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] asf-ci commented on pull request #21838: [21826]- beam post commit java sickbay fails

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21838:
URL: https://github.com/apache/beam/pull/21838#issuecomment-1154447329

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] closed pull request #21838: [21826] - beam post commit java sickbay fails

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #21838: [21826] - beam post commit java sickbay fails
URL: https://github.com/apache/beam/pull/21838


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org