You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/01/02 20:01:08 UTC
Re: Review Request 71860: Moved creating authorization Object out of
`Master::authorizeFramework`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71860/
-----------------------------------------------------------
(Updated Jan. 2, 2020, 8:01 p.m.)
Review request for mesos, Benjamin Bannier and Benjamin Mahler.
Bugs: MESOS-10023 and MESOS-10056
https://issues.apache.org/jira/browse/MESOS-10023
https://issues.apache.org/jira/browse/MESOS-10056
Repository: mesos
Description
-------
Moved creating authorization Object out of `Master::authorizeFramework`.
Diffs (updated)
-----
src/master/authorization.hpp PRE-CREATION
src/master/authorization.cpp PRE-CREATION
src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869
Diff: https://reviews.apache.org/r/71860/diff/2/
Changes: https://reviews.apache.org/r/71860/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 71860: Moved creating authorization Object out of
`Master::authorizeFramework`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71860/#review219137
-----------------------------------------------------------
Ship it!
Had to manually apply the changes here, since my edits to the last patch made the tooling complain. Will push shortly!
- Benjamin Mahler
On Jan. 2, 2020, 8:01 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71860/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2020, 8:01 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-10023 and MESOS-10056
> https://issues.apache.org/jira/browse/MESOS-10023
> https://issues.apache.org/jira/browse/MESOS-10056
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved creating authorization Object out of `Master::authorizeFramework`.
>
>
> Diffs
> -----
>
> src/master/authorization.hpp PRE-CREATION
> src/master/authorization.cpp PRE-CREATION
> src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869
>
>
> Diff: https://reviews.apache.org/r/71860/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>