[GitHub] [hudi] YannByron commented on a diff in pull request #6824: [HUDI-4946] fix merge into with no preCombineField has dup row by onl…

[GitBox <gi...@apache.org>]

YannByron commented on code in PR #6824:
URL: https://github.com/apache/hudi/pull/6824#discussion_r999614340


##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala:
##########
@@ -160,7 +167,7 @@ case class MergeIntoHoodieTableCommand(mergeInto: MergeIntoTable) extends Hoodie
 
       // column order changed after left anti join , we should keep column order of source dataframe
       val cols = removeMetaFields(sourceDF).columns
-      executeInsertOnly(insertSourceDF.select(cols.head, cols.tail:_*), parameters)
+      executeInsertOnly(insertSourceDF.select(cols.head, cols.tail:_*), writeParam)

Review Comment:
   @KnightChess I think this pr wants to guarantee write consistency no matter whether the `when matched then` clause is present or not.
   So maybe better to split this UT to two, one has configured `preCombineField`, and another not. And both of UT contains two cases that have `when matched then` or not. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org