You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/20 03:36:40 UTC
[GitHub] [rocketmq] humkum opened a new issue #3662: Push client metrics to a common statistics server instead of broker call client by itself to avoid extra RPC calls.
humkum opened a new issue #3662:
URL: https://github.com/apache/rocketmq/issues/3662
The issue tracker is **ONLY** used for bug report(feature request need to follow [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal)). Keep in mind, please check whether there is an existing same report before your raise a new one.
Alternately (especially if your communication is not a bug report), you can send mail to our [mailing lists](http://rocketmq.apache.org/about/contact/). We welcome any friendly suggestions, bug fixes, collaboration and other improvements.
Please ensure that your bug report is clear and that it is complete. Otherwise, we may be unable to understand it or to reproduce it, either of which would prevent us from fixing the bug. We strongly recommend the report(bug report or feature request) could include some hints as the following:
**BUG REPORT**
1. Please describe the issue you observed:
- What did you do (The steps to reproduce)?
- What did you expect to see?
- What did you see instead?
2. Please tell us about your environment:
3. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):
**FEATURE REQUEST**
1. Please describe the feature you are requesting.
Hello. We found that the client's runtime metrics are collected on the client, but when the rocketmq-exporter obtains these metrics, it first requests the broker, and then the broker uses the callConsumer() method to request the client to obtain them.
There are two problems are currently found:
1. If the version of the client is behind the server, the broker may fail to request runtime metrics from the client, resulting in the rocketmq-exporter not being able to collect the runtime metrics of the consumer.
2. Every time the consumer's runtime metrics are obtained, the broker requests the client, which will inevitably cause additional RPC calls.
Based on the above problems, we consider collecting client metrics on the client side, and then push the metrics to the same statistics node by actively pushing. At the same time, in order to make the client runtime metrics more accurate, we consider using the Metrics tool to count these metrics. In addition, we designed this module as a plug-in, which users can switch on and off.
2. Provide any additional detail on your proposed use case for this feature.
3. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:
- [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 description here,
- [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 description here,
- ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ni-ze commented on issue #3662: Push client metrics to a common statistics server instead of broker call client by itself to avoid extra RPC calls.
Posted by GitBox <gi...@apache.org>.
ni-ze commented on issue #3662:
URL: https://github.com/apache/rocketmq/issues/3662#issuecomment-998409702
sub-task links to nothing, look forward to provide more details. Storing statistics data with extra node will ause a waste of resources. And not everyone has a demand of collect all client statistics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] MatrixHB edited a comment on issue #3662: Push client metrics to a common statistics server instead of broker call client by itself to avoid extra RPC calls.
Posted by GitBox <gi...@apache.org>.
MatrixHB edited a comment on issue #3662:
URL: https://github.com/apache/rocketmq/issues/3662#issuecomment-998033603
When you said 'a common statistics server', do you mean using broker or using extra node to store the statistics data?
Is it wasteful to introduce at least two nodes just for storage of runtime statistics data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] MatrixHB edited a comment on issue #3662: Push client metrics to a common statistics server instead of broker call client by itself to avoid extra RPC calls.
Posted by GitBox <gi...@apache.org>.
MatrixHB edited a comment on issue #3662:
URL: https://github.com/apache/rocketmq/issues/3662#issuecomment-998033603
When you said 'a common statistics server', do you mean using broker or using extra node to store the statistics data?
Is it wasteful to introducing at least two nodes just for storage of runtime statistics data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] guyinyou commented on issue #3662: Push client metrics to a common statistics server instead of broker call client by itself to avoid extra RPC calls.
Posted by GitBox <gi...@apache.org>.
guyinyou commented on issue #3662:
URL: https://github.com/apache/rocketmq/issues/3662#issuecomment-1000111263
Starting from the problem, it should be because different uses have different requirements. The rpc call method ensures that the data obtained by each call is useful. But if you switch to real-time push, there may be a lot of ineffective waste of resources. Unless there is a real-time computing scenario demand, maybe there are other better solutions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] MatrixHB commented on issue #3662: Push client metrics to a common statistics server instead of broker call client by itself to avoid extra RPC calls.
Posted by GitBox <gi...@apache.org>.
MatrixHB commented on issue #3662:
URL: https://github.com/apache/rocketmq/issues/3662#issuecomment-998033603
When you said 'a common statistics server', do you mean using broker or using extra node to store the statistics data?
Is it wasteful to introducing at least two nodes just for storage of runtime statistics data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] odbozhou commented on issue #3662: Push client metrics to a common statistics server instead of broker call client by itself to avoid extra RPC calls.
Posted by GitBox <gi...@apache.org>.
odbozhou commented on issue #3662:
URL: https://github.com/apache/rocketmq/issues/3662#issuecomment-998496388
I think we should start from the point of view of the problem?
Does the rpc call to obtain client statistics really have any impact?
If the client's statistical data is inaccurate, can it be solved by optimizing the statistical code? The introduction of the new metrics tool may not necessarily solve the problem better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org