You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "nchammas (via GitHub)" <gi...@apache.org> on 2024/01/18 15:25:21 UTC
[PR] [MINOR][DOCS] Remove unneeded production tag block method [spark]
nchammas opened a new pull request, #44788:
URL: https://github.com/apache/spark/pull/44788
### What changes were proposed in this pull request?
Remove an unneeded method override in the definition of `ProductionTag`.
### Why are the changes needed?
It's just noise.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
I built the docs and confirmed that this script block shows up only when `PRODUCTION=1`: https://github.com/apache/spark/blob/71468ebcc85e2694935086dcf0b01bfe2bff745f/docs/_layouts/global.html#L35-L52
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Remove unneeded production tag block method [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44788:
URL: https://github.com/apache/spark/pull/44788#issuecomment-1899478775
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Remove unneeded production tag block method [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44788: [MINOR][DOCS] Remove unneeded production tag block method
URL: https://github.com/apache/spark/pull/44788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org