You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2020/08/20 09:05:26 UTC

[GitHub] [karaf] gmcdonald opened a new pull request #1164: whitespace

gmcdonald opened a new pull request #1164:
URL: https://github.com/apache/karaf/pull/1164


   test PR, so not merge


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre commented on pull request #1164: whitespace

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1164:
URL: https://github.com/apache/karaf/pull/1164#issuecomment-678730814


   @gmcdonald it seems that neither PR job or multibranch don't build PR. Any idea ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] gmcdonald commented on pull request #1164: whitespace

Posted by GitBox <gi...@apache.org>.
gmcdonald commented on pull request #1164:
URL: https://github.com/apache/karaf/pull/1164#issuecomment-677510328


   I am wondering if the problem is that this is a Maven type job and cant be used with GH App creds.
   
   Any way you can copy this job into a multibranch or Org Folder type job?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] skitt commented on pull request #1164: whitespace

Posted by GitBox <gi...@apache.org>.
skitt commented on pull request #1164:
URL: https://github.com/apache/karaf/pull/1164#issuecomment-677487954


   @gmcdonald you can convert this to a draft, that way it won’t risk being merged ;-). All the checks should still run. On the right-hand-side, in the “Reviewers” section, click on “Still in progress? Convert to draft”.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre closed pull request #1164: whitespace

Posted by GitBox <gi...@apache.org>.
jbonofre closed pull request #1164:
URL: https://github.com/apache/karaf/pull/1164


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] gmcdonald commented on pull request #1164: whitespace

Posted by GitBox <gi...@apache.org>.
gmcdonald commented on pull request #1164:
URL: https://github.com/apache/karaf/pull/1164#issuecomment-677509720


   > @gmcdonald you can convert this to a draft, that way it won’t risk being merged ;-). All the checks should still run. On the right-hand-side, in the “Reviewers” section, click on “Still in progress? Convert to draft”.
   
   Now why didnt I think of that!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre commented on pull request #1164: whitespace

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1164:
URL: https://github.com/apache/karaf/pull/1164#issuecomment-677630000


   @gmcdonald we already have a multibranch project on new-builds as well. However, I wanted to avoid to create multibranch/org folder to mimic what we had before on buids.a.o.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org