You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by Al Wei <wz...@163.com> on 2020/12/07 09:14:33 UTC
Coding Implementation doesn't correspond to the design
When I'm looking through the recovery processing, I find one problem in master branch:
An empty file'll have a field "crashed" that is assigned "true" in org.apache.iotdb.tsfile.write.writer.RestorableTsFileIOWriter#RestorableTsFileIOWriter. However, according to the design docs, an empty file will have a field "crashed" that is assigned "false".
Does this affect something?
related jira issue IOTDB-1042
Re: Coding Implementation doesn't correspond to the design
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,
I checked the codes. There is no bug.
But, indeed I think the field name `crashed` is not quite apropos.
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Al Wei <wz...@163.com> 于2020年12月7日周一 下午5:14写道：
> When I'm looking through the recovery processing, I find one problem in
> master branch:
> An empty file'll have a field "crashed" that is assigned "true" in
> org.apache.iotdb.tsfile.write.writer.RestorableTsFileIOWriter#RestorableTsFileIOWriter.
> However, according to the design docs, an empty file will have a field
> "crashed" that is assigned "false".
> Does this affect something?
> related jira issue IOTDB-1042