You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/09 11:31:35 UTC
[GitHub] [incubator-nuttx] pussuw opened a new pull request, #6820: mpfs: Remove the ddrstorage section from the OpenSBI package
pussuw opened a new pull request, #6820:
URL: https://github.com/apache/incubator-nuttx/pull/6820
It is not really needed; g_hart_stacks is only used during SBI init as
a temporary stack area. We can use the scratch area buffers for this, as
the scratch areas define almost 4K of extra space, which is used for
exception stacks anyway.
## Summary
Free up 40K of DDR when using OpenSBI
## Impact
Only when OpenSBI is in use
## Testing
icicle:knsh + OpenSBI v1.0 (with MPFS wrapper)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6820: mpfs: Remove the ddrstorage section from the OpenSBI package
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6820:
URL: https://github.com/apache/incubator-nuttx/pull/6820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6820: mpfs: Remove the ddrstorage section from the OpenSBI package
Posted by GitBox <gi...@apache.org>.
pussuw commented on code in PR #6820:
URL: https://github.com/apache/incubator-nuttx/pull/6820#discussion_r941239223
##########
arch/risc-v/src/mpfs/mpfs_opensbi.c:
##########
@@ -232,15 +232,9 @@ static const struct sbi_platform platform =
/* This must go into l2_scratchpad region, starting at 0x0a000000. */
-static sbi_scratch_holder_t g_scratches[MPFS_MAX_NUM_HARTS] \
+sbi_scratch_holder_t g_scratches[MPFS_MAX_NUM_HARTS] \
__attribute__((section(".l2_scratchpad")));
-/* These stacks are used in the mpfs_opensbi_utils.S */
-
-uint8_t g_hart_stacks[SBI_PLATFORM_DEFAULT_HART_STACK_SIZE * \
- MPFS_HART_COUNT] \
Review Comment:
Yes it can be removed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] eenurkka commented on a diff in pull request #6820: mpfs: Remove the ddrstorage section from the OpenSBI package
Posted by GitBox <gi...@apache.org>.
eenurkka commented on code in PR #6820:
URL: https://github.com/apache/incubator-nuttx/pull/6820#discussion_r941233869
##########
arch/risc-v/src/mpfs/mpfs_opensbi.c:
##########
@@ -232,15 +232,9 @@ static const struct sbi_platform platform =
/* This must go into l2_scratchpad region, starting at 0x0a000000. */
-static sbi_scratch_holder_t g_scratches[MPFS_MAX_NUM_HARTS] \
+sbi_scratch_holder_t g_scratches[MPFS_MAX_NUM_HARTS] \
__attribute__((section(".l2_scratchpad")));
-/* These stacks are used in the mpfs_opensbi_utils.S */
-
-uint8_t g_hart_stacks[SBI_PLATFORM_DEFAULT_HART_STACK_SIZE * \
- MPFS_HART_COUNT] \
Review Comment:
Maybe this is no londer needed (line 67):
```
#if SBI_PLATFORM_DEFAULT_HART_STACK_SIZE != 8192
# error "Fix define in file mpfs_opensbi_utils.S"
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] eenurkka commented on a diff in pull request #6820: mpfs: Remove the ddrstorage section from the OpenSBI package
Posted by GitBox <gi...@apache.org>.
eenurkka commented on code in PR #6820:
URL: https://github.com/apache/incubator-nuttx/pull/6820#discussion_r941233869
##########
arch/risc-v/src/mpfs/mpfs_opensbi.c:
##########
@@ -232,15 +232,9 @@ static const struct sbi_platform platform =
/* This must go into l2_scratchpad region, starting at 0x0a000000. */
-static sbi_scratch_holder_t g_scratches[MPFS_MAX_NUM_HARTS] \
+sbi_scratch_holder_t g_scratches[MPFS_MAX_NUM_HARTS] \
__attribute__((section(".l2_scratchpad")));
-/* These stacks are used in the mpfs_opensbi_utils.S */
-
-uint8_t g_hart_stacks[SBI_PLATFORM_DEFAULT_HART_STACK_SIZE * \
- MPFS_HART_COUNT] \
Review Comment:
Maybe this is no londer needed (line 67):
#if SBI_PLATFORM_DEFAULT_HART_STACK_SIZE != 8192
# error "Fix define in file mpfs_opensbi_utils.S"
#endif
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org